Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: components/gcm_driver/crypto/encryption_header_parsers_unittest.cc

Issue 1244803002: Add parsers for the Encryption and Encryption-Key HTTP headers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/gcm_driver/crypto/encryption_header_parsers_unittest.cc
diff --git a/components/gcm_driver/crypto/encryption_header_parsers_unittest.cc b/components/gcm_driver/crypto/encryption_header_parsers_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..d3a2b1329b42b089b8f7360c4f53346861c64e45
--- /dev/null
+++ b/components/gcm_driver/crypto/encryption_header_parsers_unittest.cc
@@ -0,0 +1,208 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/gcm_driver/crypto/encryption_header_parsers.h"
+
+#include <vector>
+
+#include "base/macros.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace gcm {
+
+namespace {
+
+// URL-safe base64 encoded (and plaintext representation of -) salt, key and dh.
+// Included as preprocessor string literals for more convenient concatenation.
+#define ENCODED_SALT "c2l4dGVlbmNvb2xieXRlcw"
+#define ENCODED_KEY "c2V2ZW50ZWVuYnl0ZXN5YXk"
+#define ENCODED_DH "bXlkaWZmaWVoZWxsbWFu"
+
+const char kDecodedSalt[] = "sixteencoolbytes";
+const char kDecodedKey[] = "seventeenbytesyay";
+const char kDecodedDh[] = "mydiffiehellman";
+
+EncryptionHeaderValue CreateEncryptionHeaderValue(
+ const std::string& keyid, const std::string& salt, int64_t rs) {
+ EncryptionHeaderValue parsed;
+ parsed.keyid = keyid;
+ parsed.salt = salt;
+ parsed.rs = rs;
+
+ return parsed;
+}
+
+EncryptionKeyHeaderValue CreateEncryptionKeyHeaderValue(
+ const std::string& keyid, const std::string& key, const std::string& dh) {
+ EncryptionKeyHeaderValue header;
+ header.keyid = keyid;
+ header.key = key;
+ header.dh = dh;
+
+ return header;
+}
+
+TEST(EncryptionHeaderParsersTest, ParseSingleEncryptionHeaders) {
+ struct {
+ const char* const header;
+ EncryptionHeaderValue parsed;
+ } expected_results[] = {
+ { "keyid=foo; salt=" ENCODED_SALT "; rs=1024",
+ CreateEncryptionHeaderValue("foo", kDecodedSalt, 1024) },
+ { "KEYID=foo; SALT=" ENCODED_SALT "; RS=1024",
+ CreateEncryptionHeaderValue("foo", kDecodedSalt, 1024) },
+ { "keyid='foo'; salt='" ENCODED_SALT "'; rs='1024'",
+ CreateEncryptionHeaderValue("foo", kDecodedSalt, 1024) },
+ { "keyid=\"foo\"; salt=\"" ENCODED_SALT "\"; rs=\"1024\"",
+ CreateEncryptionHeaderValue("foo", kDecodedSalt, 1024) },
+ { "keyid=foo;salt=" ENCODED_SALT ";rs=1024",
+ CreateEncryptionHeaderValue("foo", kDecodedSalt, 1024) },
+ { "keyid=foo;salt=" ENCODED_SALT ";rs=1024;random=yes",
+ CreateEncryptionHeaderValue("foo", kDecodedSalt, 1024) },
+ { "rs=1024; salt=" ENCODED_SALT "; keyid=foo",
+ CreateEncryptionHeaderValue("foo", kDecodedSalt, 1024) },
+ { "salt=" ENCODED_SALT "; keyid='foo; rs=1024'",
+ CreateEncryptionHeaderValue("foo; rs=1024", kDecodedSalt, 4096) },
+ { "salt=" ENCODED_SALT "; rs=1024",
+ CreateEncryptionHeaderValue("", kDecodedSalt, 1024) },
+ { "salt=" ENCODED_SALT,
+ CreateEncryptionHeaderValue("", kDecodedSalt, 4096) }
+ };
+
+ for (size_t i = 0; i < arraysize(expected_results); i++) {
+ SCOPED_TRACE(i);
+
+ std::vector<EncryptionHeaderValue> result;
+ ASSERT_TRUE(ParseEncryptionHeader(expected_results[i].header, &result));
+ ASSERT_EQ(1u, result.size());
+
+ EXPECT_EQ(expected_results[i].parsed.keyid, result[0].keyid);
+ EXPECT_EQ(expected_results[i].parsed.salt, result[0].salt);
+ EXPECT_EQ(expected_results[i].parsed.rs, result[0].rs);
+ }
+}
+
+TEST(EncryptionHeaderParsersTest, ParseInvalidSingleEncryptionHeaders) {
+ const char* const expected_failures[] = {
+ // The "salt" attribute is required.
+ "keyid=foo",
+ // The "salt" attribute must be exactly 16-bytes, base64url encoded.
+ "salt=foobar",
+ "salt='c2l4dGVlbmNv/2xieXRlcw'",
+ // Non-decimal record sizes are not supported.
+ "salt=" ENCODED_SALT ";rs=bar",
+ // Record sizes smaller than 2 are not supported.
+ "salt=" ENCODED_SALT ";rs=0",
+ // Record sizes exceeding the range of int64 are not supported.
+ "salt=" ENCODED_SALT ";rs=9223372036854775808"
+ };
+
+ for (size_t i = 0; i < arraysize(expected_failures); i++) {
+ SCOPED_TRACE(i);
+
+ std::vector<EncryptionHeaderValue> result;
+ ASSERT_FALSE(ParseEncryptionHeader(expected_failures[i], &result));
+ EXPECT_EQ(0u, result.size());
+ }
+}
+
+TEST(EncryptionHeaderParsersTest, ParseMultipleEncryptionHeaders) {
+ const char* const header =
+ "keyid=foo1; salt=" ENCODED_SALT "; rs=1024,,"
+ "keyid='foo2, '; salt=" ENCODED_SALT "; rs=2048";
+
+ std::vector<EncryptionHeaderValue> results;
+ ASSERT_TRUE(ParseEncryptionHeader(header, &results));
+ ASSERT_EQ(2u, results.size());
+
+ EXPECT_EQ("foo1", results[0].keyid);
+ EXPECT_EQ(kDecodedSalt, results[0].salt);
+ EXPECT_EQ(1024, results[0].rs);
+
+ EXPECT_EQ("foo2, ", results[1].keyid);
+ EXPECT_EQ(kDecodedSalt, results[1].salt);
+ EXPECT_EQ(2048, results[1].rs);
+}
+
+TEST(EncryptionHeaderParsersTest, ParseSingleEncryptionKeyHeader) {
+ struct {
+ const char* const header;
+ EncryptionKeyHeaderValue parsed;
+ } expected_results[] = {
+ { "keyid=foo; key=" ENCODED_KEY "; dh=" ENCODED_DH,
+ CreateEncryptionKeyHeaderValue("foo", kDecodedKey, kDecodedDh) },
+ { "KEYID=foo; KEY=" ENCODED_KEY "; DH=" ENCODED_DH,
+ CreateEncryptionKeyHeaderValue("foo", kDecodedKey, kDecodedDh) },
+ { "keyid='foo'; key='" ENCODED_KEY "'; dh='" ENCODED_DH "'",
+ CreateEncryptionKeyHeaderValue("foo", kDecodedKey, kDecodedDh) },
+ { "keyid=\"foo\"; key=\"" ENCODED_KEY "\"; dh=\"" ENCODED_DH "\"",
+ CreateEncryptionKeyHeaderValue("foo", kDecodedKey, kDecodedDh) },
+ { "keyid=foo;key=" ENCODED_KEY ";dh=" ENCODED_DH "",
+ CreateEncryptionKeyHeaderValue("foo", kDecodedKey, kDecodedDh) },
+ { "keyid=foo;key=" ENCODED_KEY ";dh=" ENCODED_DH ";random=yes",
+ CreateEncryptionKeyHeaderValue("foo", kDecodedKey, kDecodedDh) },
+ { "dh=" ENCODED_DH "; key=" ENCODED_KEY "; keyid=foo",
+ CreateEncryptionKeyHeaderValue("foo", kDecodedKey, kDecodedDh) },
+ { "keyid=foo",
+ CreateEncryptionKeyHeaderValue("foo", "", "") },
+ { "key=" ENCODED_KEY "",
+ CreateEncryptionKeyHeaderValue("", kDecodedKey, "") },
+ { "dh=" ENCODED_DH "",
+ CreateEncryptionKeyHeaderValue("", "", kDecodedDh) }
+ };
+
+ for (size_t i = 0; i < arraysize(expected_results); i++) {
+ SCOPED_TRACE(i);
+
+ std::vector<EncryptionKeyHeaderValue> result;
+ ASSERT_TRUE(ParseEncryptionKeyHeader(expected_results[i].header, &result));
+ ASSERT_EQ(1u, result.size());
+
+ EXPECT_EQ(expected_results[i].parsed.keyid, result[0].keyid);
+ EXPECT_EQ(expected_results[i].parsed.key, result[0].key);
+ EXPECT_EQ(expected_results[i].parsed.dh, result[0].dh);
+ }
+}
+
+TEST(EncryptionHeaderParsersTest, ParseInvalidSingleEncryptionKeyHeaders) {
+ const char* const expected_failures[] = {
+ // The "key" attribute must be at least 16-bytes, base64url encoded.
+ "key=foo/bar",
+ "key=c2hvcnRrZXk",
+ "key='c2l4dGVlbmNvb2/ieXRlcw'",
+ // The "dh" attribute must contain a base64url encoded-value.
+ "dh=foo/bar",
+ "dh='ZGg/'"
+ };
+
+ for (size_t i = 0; i < arraysize(expected_failures); i++) {
+ SCOPED_TRACE(i);
+
+ std::vector<EncryptionKeyHeaderValue> result;
+ ASSERT_FALSE(ParseEncryptionKeyHeader(expected_failures[i], &result));
+ EXPECT_EQ(0u, result.size());
+ }
+}
+
+TEST(EncryptionHeaderParsersTest, ParseMultipleEncryptionKeyHeaders) {
+ const char* const header =
+ "keyid=foo1; key=" ENCODED_KEY "; dh=" ENCODED_DH ","
+ "keyid='foo2, '; key=c29tZW90aGVybG9uZ2tleQ; dh=ZGhmb29iYXI";
+
+ std::vector<EncryptionKeyHeaderValue> results;
+ ASSERT_TRUE(ParseEncryptionKeyHeader(header, &results));
+ ASSERT_EQ(2u, results.size());
+
+ EXPECT_EQ("foo1", results[0].keyid);
+ EXPECT_EQ(kDecodedKey, results[0].key);
+ EXPECT_EQ(kDecodedDh, results[0].dh);
+
+ EXPECT_EQ("foo2, ", results[1].keyid);
+ EXPECT_EQ("someotherlongkey", results[1].key);
+ EXPECT_EQ("dhfoobar", results[1].dh);
+}
+
+} // namespace
+
+} // namespace gcm

Powered by Google App Engine
This is Rietveld 408576698