chrome/browser/ssl/certificate_reporting_test_utils.h - Issue 1244783006: Add Finch testing configs for ReportCertificateErrors study

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ssl/certificate_reporting_test_utils.h

Issue 1244783006: Add Finch testing configs for ReportCertificateErrors study (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix GetLatestHostnameReported() const definition Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ssl/captive_portal_blocking_page_browsertest.cc ('k') | chrome/browser/ssl/certificate_reporting_test_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ssl/certificate_reporting_test_utils.h

diff --git a/chrome/browser/ssl/certificate_reporting_test_utils.h b/chrome/browser/ssl/certificate_reporting_test_utils.h

index 6b7bdae21b1dee3e9573fde5644b6ec30f90a4fe..a397e7049be12efda57b7e18468f8e27787cb5f1 100644

--- a/chrome/browser/ssl/certificate_reporting_test_utils.h

+++ b/chrome/browser/ssl/certificate_reporting_test_utils.h

@@ -38,7 +38,7 @@ class CertificateReportingTest : public InProcessBrowserTest {

protected:

// Get the latest hostname for which a certificate report was sent.

- const std::string& GetLatestHostnameReported();

+ const std::string& GetLatestHostnameReported() const;

private:

MockReporter* reporter_;

@@ -55,10 +55,9 @@ scoped_ptr<SSLCertReporter> SetUpMockSSLCertReporter(

base::RunLoop* run_loop,

ExpectReport expect_report);

-// Forces a Finch config for the cert reporting experiment.

-void SetCertReportingFinchConfig(const std::string& group_name,

- const std::string& param_value);

-void SetCertReportingFinchConfig(const std::string& group_name);

+// Returns whether a report should be expected (due to the Finch config)

+// if the user opts in.

+ExpectReport GetReportExpectedFromFinch();

} // namespace CertificateReportingTestUtils