Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Side by Side Diff: chrome/common/chrome_version_info.h

Issue 1244773003: Remove unusued instance variable of chrome::VersionInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add missing #include in chrome/app/close_handle_hook_win.cc Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/app/close_handle_hook_win.cc ('k') | chrome/common/chrome_version_info.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_COMMON_CHROME_VERSION_INFO_H_ 5 #ifndef CHROME_COMMON_CHROME_VERSION_INFO_H_
6 #define CHROME_COMMON_CHROME_VERSION_INFO_H_ 6 #define CHROME_COMMON_CHROME_VERSION_INFO_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
11 #include "base/memory/scoped_ptr.h"
12
13 class FileVersionInfo;
14 11
15 namespace chrome { 12 namespace chrome {
16 13
17 // An instance of chrome::VersionInfo has information about the 14 // An instance of chrome::VersionInfo has information about the
18 // current running build of Chrome. 15 // current running build of Chrome.
19 class VersionInfo { 16 class VersionInfo {
20 public: 17 public:
21 // The possible channels for an installation, from most fun to most stable. 18 // The possible channels for an installation, from most fun to most stable.
22 enum Channel { 19 enum Channel {
23 CHANNEL_UNKNOWN = 0, // Probably blue 20 CHANNEL_UNKNOWN = 0, // Probably blue
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 71
75 #if defined(OS_CHROMEOS) 72 #if defined(OS_CHROMEOS)
76 // Sets channel before use. 73 // Sets channel before use.
77 static void SetChannel(const std::string& channel); 74 static void SetChannel(const std::string& channel);
78 #endif 75 #endif
79 76
80 // Returns a version string to be displayed in "About Chromium" dialog. 77 // Returns a version string to be displayed in "About Chromium" dialog.
81 std::string CreateVersionString() const; 78 std::string CreateVersionString() const;
82 79
83 private: 80 private:
84 #if defined(OS_WIN) || defined(OS_MACOSX)
85 scoped_ptr<FileVersionInfo> version_info_;
86 #endif
87
88 DISALLOW_COPY_AND_ASSIGN(VersionInfo); 81 DISALLOW_COPY_AND_ASSIGN(VersionInfo);
89 }; 82 };
90 83
91 } // namespace chrome 84 } // namespace chrome
92 85
93 #endif // CHROME_COMMON_CHROME_VERSION_INFO_H_ 86 #endif // CHROME_COMMON_CHROME_VERSION_INFO_H_
OLDNEW
« no previous file with comments | « chrome/app/close_handle_hook_win.cc ('k') | chrome/common/chrome_version_info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698