content/browser/renderer_host/render_widget_host_view_mac_dictionary_helper.mm - Issue 1244723003: [Mac] Update context menu dictionary lookup wording and placement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac_dictionary_helper.mm

Issue 1244723003: [Mac] Update context menu dictionary lookup wording and placement. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/renderer_context_menu/render_view_context_menu.h ('K') | « chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_mac_dictionary_helper.mm

diff --git a/content/browser/renderer_host/render_widget_host_view_mac_dictionary_helper.mm b/content/browser/renderer_host/render_widget_host_view_mac_dictionary_helper.mm

index bcae7ec4e4e9bdd4549fd1f20c6c6b0785057a50..ea4a0f8a9898ca41a305fd14d7a0a91746e5a189 100644

--- a/content/browser/renderer_host/render_widget_host_view_mac_dictionary_helper.mm

+++ b/content/browser/renderer_host/render_widget_host_view_mac_dictionary_helper.mm

@@ -23,7 +23,7 @@ void RenderWidgetHostViewMacDictionaryHelper::ShowDefinitionForSelection() {

NSRange selection_range = [view_->cocoa_view() selectedRange];

NSAttributedString* attr_string =

[view_->cocoa_view() attributedSubstringForProposedRange:selection_range

- actualRange:nil];

+ actualRange:nil];

if (!attr_string) {

if (view_->selected_text().empty())

return;