Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Issue 1244723003: [Mac] Update context menu dictionary lookup wording and placement. (Closed)

Created:
5 years, 5 months ago by Bons
Modified:
5 years, 5 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Update context menu dictionary lookup wording and placement. + It is now consistent with newer versions of OS X. - the copy is Look Up “Foo” instead of Look Up In Dictionary. - It will not display when right clicking a link. - The item now appears first in the context menu. BUG= TEST=Right click a word on a web page, and see that it says "Look Up “<WORD>” Committed: https://crrev.com/6fd52e31752157dbbfac2a345f41ce0dc685e428 Cr-Commit-Position: refs/heads/master@{#339659}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -39 lines) Patch
M chrome/app/chrome_command_ids.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/generated_resources.grd View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/renderer_context_menu/render_view_context_menu.h View 1 2 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/renderer_context_menu/render_view_context_menu.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac.mm View 3 chunks +28 lines, -21 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_dictionary_helper.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (9 generated)
Bons
5 years, 5 months ago (2015-07-21 04:48:31 UTC) #2
Avi (use Gerrit)
driveby https://codereview.chromium.org/1244723003/diff/1/chrome/browser/renderer_context_menu/render_view_context_menu.h File chrome/browser/renderer_context_menu/render_view_context_menu.h (right): https://codereview.chromium.org/1244723003/diff/1/chrome/browser/renderer_context_menu/render_view_context_menu.h#newcode68 chrome/browser/renderer_context_menu/render_view_context_menu.h:68: // suitable or putting in the title of ...
5 years, 5 months ago (2015-07-21 05:18:53 UTC) #3
Avi (use Gerrit)
On 2015/07/21 05:18:53, Avi wrote: > driveby > > https://codereview.chromium.org/1244723003/diff/1/chrome/browser/renderer_context_menu/render_view_context_menu.h > File chrome/browser/renderer_context_menu/render_view_context_menu.h (right): > ...
5 years, 5 months ago (2015-07-21 05:20:16 UTC) #4
Bons
https://codereview.chromium.org/1244723003/diff/1/chrome/browser/renderer_context_menu/render_view_context_menu.h File chrome/browser/renderer_context_menu/render_view_context_menu.h (right): https://codereview.chromium.org/1244723003/diff/1/chrome/browser/renderer_context_menu/render_view_context_menu.h#newcode68 chrome/browser/renderer_context_menu/render_view_context_menu.h:68: // suitable or putting in the title of a ...
5 years, 5 months ago (2015-07-21 05:51:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1244723003/20001
5 years, 5 months ago (2015-07-21 05:51:40 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/80387)
5 years, 5 months ago (2015-07-21 06:02:12 UTC) #10
Bons
adding grt for chrome/app/chrome_command_ids.h
5 years, 5 months ago (2015-07-21 06:06:28 UTC) #13
grt (UTC plus 2)
chrome/app/* lgtm
5 years, 5 months ago (2015-07-21 13:46:28 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1244723003/20001
5 years, 5 months ago (2015-07-21 13:50:47 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/30205)
5 years, 5 months ago (2015-07-21 15:03:32 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1244723003/20001
5 years, 5 months ago (2015-07-21 15:15:51 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-21 15:48:24 UTC) #21
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 15:49:13 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6fd52e31752157dbbfac2a345f41ce0dc685e428
Cr-Commit-Position: refs/heads/master@{#339659}

Powered by Google App Engine
This is Rietveld 408576698