Add support for adding an external and a tagged pointer

src/ia32/lithium-ia32.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <sstream>
 
 #include "src/v8.h"
 
 #if V8_TARGET_ARCH_IA32
 
@@ skipping 1612 matching lines @@
         ? DefineAsRegister(add)
         : DefineSameAsFirst(add);
     if (can_overflow) {
       result = AssignEnvironment(result);
     }
     return result;
   } else if (instr->representation().IsDouble()) {
     return DoArithmeticD(Token::ADD, instr);
   } else if (instr->representation().IsExternal()) {
     DCHECK(instr->left()->representation().IsExternal());
-    DCHECK(instr->right()->representation().IsInteger32());
+    DCHECK((instr->external_add_type() == AddOfExternalAndInt32 &&
+            instr->right()->representation().IsInteger32()) ||
+           (instr->external_add_type() == AddOfExternalAndTagged &&
+            instr->right()->representation().IsTagged()));

[Jarin, 2015/07/20 14:17:56]

Maybe you want to factor out the two DCHECK into a separate method, up to you.

Something like 

bool HAdd::IsConsistentExternalRepresentation() {
  return  left()->representation().IsExternal() && 
         ((external_add_type() == AddOfExternalAndInt32 &&
          right()->representation().IsInteger32()) ||
         (external_add_type() == AddOfExternalAndTagged &&
          right()->representation().IsTagged()));
}

     DCHECK(!instr->CheckFlag(HValue::kCanOverflow));
     bool use_lea = LAddI::UseLea(instr);
     LOperand* left = UseRegisterAtStart(instr->left());
     HValue* right_candidate = instr->right();
     LOperand* right = use_lea
         ? UseRegisterOrConstantAtStart(right_candidate)
         : UseOrConstantAtStart(right_candidate);
     LAddI* add = new(zone()) LAddI(left, right);
     LInstruction* result = use_lea
         ? DefineAsRegister(add)
@@ skipping 1145 matching lines @@
   LAllocateBlockContext* result =
       new(zone()) LAllocateBlockContext(context, function);
   return MarkAsCall(DefineFixed(result, esi), instr);
 }
 
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_TARGET_ARCH_IA32