ppapi/nacl_irt/irt_interfaces.h - Issue 1244533006: NaCl cleanup: Split out irt_interfaces.cc from irt_ppapi.cc

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ppapi/nacl_irt/irt_interfaces.h

Issue 1244533006: NaCl cleanup: Split out irt_interfaces.cc from irt_ppapi.cc (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef PPAPI_NACL_IRT_IRT_INTERFACES_H_

	6 #define PPAPI_NACL_IRT_IRT_INTERFACES_H_

	7

	8 #include <stdlib.h>

	9

	10 extern const struct nacl_irt_ppapihook nacl_irt_ppapihook;
	bbudge 2015/07/20 17:21:09 Is there a reason this is declared here and not in Is there a reason this is declared here and not in irt_ppapi.h? It's defined in irt_ppapi.cc. Mark Seaborn 2015/07/20 17:49:08 The idea was to copy how it's done in native_clien Show quoted text On 2015/07/20 17:21:09, bbudge wrote: > Is there a reason this is declared here and not in irt_ppapi.h? It's defined in > irt_ppapi.cc. The idea was to copy how it's done in native_client/src/untrusted/irt/irt_interfaces.h. I'll be adding irt_pnacl_translator_{compile,link}.cc in a follow-on change. While I could put the struct decls in separate .h files, that leads to having a lot of .h files containing one decl each.
	11

	12 size_t chrome_irt_query(const char* interface_ident,

	13 void* table, size_t tablesize);

	14

	15 #endif // PPAPI_NACL_IRT_IRT_INTERFACES_H_

OLD	NEW

« no previous file with comments | « components/nacl/loader/nonsfi/nonsfi_main.cc ('k') | ppapi/nacl_irt/irt_interfaces.cc » ('j') | no next file with comments »