Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1244493002: Wholesale move sky/engine/tonic to tonic (Closed)

Created:
5 years, 5 months ago by Cutch
Modified:
5 years, 5 months ago
Reviewers:
abarth, abarth-chromium
CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2816 lines, -15 lines) Patch
A tonic/BUILD.gn View 1 2 1 chunk +69 lines, -0 lines 0 comments Download
A tonic/dart_api_scope.h View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
A tonic/dart_builtin.h View 1 2 1 chunk +42 lines, -0 lines 0 comments Download
A tonic/dart_builtin.cc View 1 2 1 chunk +56 lines, -0 lines 0 comments Download
A tonic/dart_class_library.h View 1 2 1 chunk +33 lines, -0 lines 0 comments Download
A tonic/dart_class_library.cc View 1 2 1 chunk +34 lines, -0 lines 0 comments Download
A tonic/dart_class_provider.h View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
A + tonic/dart_class_provider.cc View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
A tonic/dart_converter.h View 1 2 1 chunk +383 lines, -0 lines 0 comments Download
A + tonic/dart_converter.cc View 1 2 1 chunk +2 lines, -6 lines 0 comments Download
A tonic/dart_dependency_catcher.h View 1 2 1 chunk +39 lines, -0 lines 0 comments Download
A tonic/dart_dependency_catcher.cc View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
A tonic/dart_error.h View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
A tonic/dart_error.cc View 1 2 1 chunk +34 lines, -0 lines 0 comments Download
A tonic/dart_exception_factory.h View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
A tonic/dart_exception_factory.cc View 1 2 1 chunk +121 lines, -0 lines 0 comments Download
A tonic/dart_gc_context.h View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
A tonic/dart_gc_context.cc View 1 2 1 chunk +30 lines, -0 lines 0 comments Download
A tonic/dart_gc_controller.h View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
A tonic/dart_gc_controller.cc View 1 2 1 chunk +52 lines, -0 lines 0 comments Download
A tonic/dart_gc_visitor.h View 1 2 1 chunk +39 lines, -0 lines 0 comments Download
A tonic/dart_gc_visitor.cc View 1 2 1 chunk +25 lines, -0 lines 0 comments Download
A tonic/dart_invoke.h View 1 2 1 chunk +23 lines, -0 lines 0 comments Download
A tonic/dart_invoke.cc View 1 2 1 chunk +28 lines, -0 lines 0 comments Download
A tonic/dart_isolate_scope.h View 1 2 1 chunk +28 lines, -0 lines 0 comments Download
A tonic/dart_isolate_scope.cc View 1 2 1 chunk +28 lines, -0 lines 0 comments Download
A tonic/dart_library_loader.h View 1 2 1 chunk +85 lines, -0 lines 0 comments Download
A tonic/dart_library_loader.cc View 1 2 1 chunk +305 lines, -0 lines 0 comments Download
A tonic/dart_library_provider.h View 1 2 1 chunk +31 lines, -0 lines 0 comments Download
A + tonic/dart_library_provider.cc View 1 2 1 chunk +4 lines, -5 lines 0 comments Download
A tonic/dart_persistent_value.h View 1 2 1 chunk +43 lines, -0 lines 0 comments Download
A tonic/dart_persistent_value.cc View 1 2 1 chunk +48 lines, -0 lines 0 comments Download
A tonic/dart_snapshot_loader.h View 1 2 1 chunk +43 lines, -0 lines 0 comments Download
A tonic/dart_snapshot_loader.cc View 1 2 1 chunk +52 lines, -0 lines 0 comments Download
A tonic/dart_state.h View 1 2 1 chunk +78 lines, -0 lines 0 comments Download
A tonic/dart_state.cc View 1 2 1 chunk +64 lines, -0 lines 0 comments Download
A tonic/dart_string.h View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
A tonic/dart_string.cc View 1 2 1 chunk +64 lines, -0 lines 0 comments Download
A tonic/dart_string_cache.h View 1 2 1 chunk +48 lines, -0 lines 0 comments Download
A tonic/dart_string_cache.cc View 1 2 1 chunk +66 lines, -0 lines 0 comments Download
A tonic/dart_timer_heap.h View 1 2 1 chunk +43 lines, -0 lines 0 comments Download
A tonic/dart_timer_heap.cc View 1 2 1 chunk +55 lines, -0 lines 0 comments Download
A tonic/dart_value.h View 1 2 1 chunk +65 lines, -0 lines 0 comments Download
A tonic/dart_value.cc View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
A tonic/dart_wrappable.h View 1 2 1 chunk +146 lines, -0 lines 0 comments Download
A tonic/dart_wrappable.cc View 1 2 1 chunk +117 lines, -0 lines 0 comments Download
A tonic/dart_wrapper_info.h View 1 2 1 chunk +28 lines, -0 lines 0 comments Download
A tonic/float32_list.h View 1 2 1 chunk +44 lines, -0 lines 0 comments Download
A tonic/float32_list.cc View 1 2 1 chunk +46 lines, -0 lines 0 comments Download
A tonic/mojo_converter.h View 1 2 1 chunk +46 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Cutch
5 years, 5 months ago (2015-07-16 18:29:04 UTC) #2
abarth-chromium
lgtm
5 years, 5 months ago (2015-07-16 18:45:40 UTC) #4
Cutch
5 years, 5 months ago (2015-07-16 19:35:41 UTC) #5
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
080c33e74af0116a195cfdbadf37f0b16e896983 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698