Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1244443003: android: Use a hard coded BeginFrame deadline (Closed)

Created:
5 years, 5 months ago by brianderson
Modified:
5 years, 5 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su, jdduke+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

android: Use a hard coded BeginFrame deadline The previous estimation logic measures the time from when the Browser receives the Renderer swap to when the Browser swaps, which may include idle time when the Renderer is in a high latency mode. This often prevented us from detecting that we can recover that latency. The correct estimation logic will look completely different for Surfaces vs. Android's current path; so the plan is to use a hard coded for now and use estimation logic again once Surfaces come to Android. BUG=510623 Committed: https://crrev.com/b91af0d2b8ff9072a376b1a8c8ebd108d536c056 Cr-Commit-Position: refs/heads/master@{#339114}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -42 lines) Patch
M content/browser/renderer_host/input/render_widget_host_latency_tracker.h View 3 chunks +0 lines, -6 lines 0 comments Download
M content/browser/renderer_host/input/render_widget_host_latency_tracker.cc View 3 chunks +1 line, -26 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
brianderson
ptal!
5 years, 5 months ago (2015-07-16 18:53:15 UTC) #2
jdduke (slow)
lgtm, shame we couldn't make this work but oh well.
5 years, 5 months ago (2015-07-16 19:03:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1244443003/1
5 years, 5 months ago (2015-07-16 19:08:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-16 20:46:53 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b91af0d2b8ff9072a376b1a8c8ebd108d536c056 Cr-Commit-Position: refs/heads/master@{#339114}
5 years, 5 months ago (2015-07-16 20:47:50 UTC) #7
mithro-old
5 years, 5 months ago (2015-07-20 07:28:24 UTC) #8
Message was sent while issue was closed.
On 2015/07/16 20:47:50, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/b91af0d2b8ff9072a376b1a8c8ebd108d536c056
> Cr-Commit-Position: refs/heads/master@{#339114}

LGTM as Brian mentioned we still want to do this, we just need different logic
for Surfaces.

Powered by Google App Engine
This is Rietveld 408576698