Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Issue 1244443002: Fix gn_migration.gypi after https://codereview.chromium.org/1231283003/ (Closed)

Created:
5 years, 5 months ago by Nico
Modified:
5 years, 5 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix gn_migration.gypi after https://codereview.chromium.org/1231283003/ Without this, building 'all' won't create the isolate file, making the isolate step after the compile step fail. BUG=98637 TBR=maruel Committed: https://crrev.com/4681b9749b14de949120cb7e2090255dd395b433 Cr-Commit-Position: refs/heads/master@{#339079}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/gn_migration.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Nico
5 years, 5 months ago (2015-07-16 17:12:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1244443002/1
5 years, 5 months ago (2015-07-16 17:15:19 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-16 18:26:17 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4681b9749b14de949120cb7e2090255dd395b433 Cr-Commit-Position: refs/heads/master@{#339079}
5 years, 5 months ago (2015-07-16 18:27:17 UTC) #6
M-A Ruel
5 years, 5 months ago (2015-07-17 01:02:00 UTC) #7
Message was sent while issue was closed.
thanks! lgtm

Powered by Google App Engine
This is Rietveld 408576698