Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1244423003: [es6] Fix function context check for super and new.target (Closed)

Created:
5 years, 5 months ago by rossberg
Modified:
5 years, 5 months ago
Reviewers:
adamk
CC:
v8-dev, Michael Starzinger
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Fix function context check for super and new.target R=adamk@chromium.org BUG=v8:3330 LOG=N Committed: https://crrev.com/47d3bb1c0b294b26e97a70988c10c756d266af84 Cr-Commit-Position: refs/heads/master@{#29803}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Comment; added test for super calls #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -28 lines) Patch
M src/preparser.h View 2 chunks +2 lines, -15 lines 0 comments Download
M src/scopes.h View 1 1 chunk +6 lines, -7 lines 0 comments Download
M src/scopes.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M test/mjsunit/harmony/new-target.js View 2 chunks +15 lines, -1 line 0 comments Download
M test/mjsunit/harmony/super.js View 1 2 chunks +30 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
rossberg
5 years, 5 months ago (2015-07-22 16:44:16 UTC) #1
adamk
lgtm % comment nit (which can happen whenever, really). https://codereview.chromium.org/1244423003/diff/1/src/scopes.h File src/scopes.h (right): https://codereview.chromium.org/1244423003/diff/1/src/scopes.h#newcode486 src/scopes.h:486: ...
5 years, 5 months ago (2015-07-22 20:55:50 UTC) #2
rossberg
Also added a test for super calls. https://codereview.chromium.org/1244423003/diff/1/src/scopes.h File src/scopes.h (right): https://codereview.chromium.org/1244423003/diff/1/src/scopes.h#newcode486 src/scopes.h:486: // Find ...
5 years, 5 months ago (2015-07-23 09:33:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1244423003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1244423003/20001
5 years, 5 months ago (2015-07-23 09:34:15 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-23 09:58:41 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-23 09:59:11 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/47d3bb1c0b294b26e97a70988c10c756d266af84
Cr-Commit-Position: refs/heads/master@{#29803}

Powered by Google App Engine
This is Rietveld 408576698