Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Issue 1244413002: Add missing EnsureOpenSSLInit to QuicStreamFactory. (Closed)

Created:
5 years, 5 months ago by davidben
Modified:
5 years, 5 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing EnsureOpenSSLInit to QuicStreamFactory. BUG=512783 Committed: https://crrev.com/78406baf2210d015caa04c59918e77142a487193 Cr-Commit-Position: refs/heads/master@{#339937}

Patch Set 1 #

Patch Set 2 : remove suppression #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M build/sanitizers/tsan_suppressions.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
davidben
5 years, 5 months ago (2015-07-22 14:07:22 UTC) #2
Alexander Potapenko
On 2015/07/22 14:07:22, David Benjamin wrote: I've started a tryjob on linux_chromium_tsan_rel_ng.
5 years, 5 months ago (2015-07-22 14:19:39 UTC) #3
Alexander Potapenko
On 2015/07/22 14:19:39, Alexander Potapenko wrote: > On 2015/07/22 14:07:22, David Benjamin wrote: > > ...
5 years, 5 months ago (2015-07-22 15:07:32 UTC) #4
Ryan Hamilton
LGTM (even if it's a bit magic :>) I wonder if we should put this ...
5 years, 5 months ago (2015-07-22 18:03:24 UTC) #5
davidben
On 2015/07/22 18:03:24, Ryan Hamilton wrote: > LGTM (even if it's a bit magic :>) ...
5 years, 5 months ago (2015-07-22 18:05:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1244413002/20001
5 years, 5 months ago (2015-07-22 18:05:46 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-22 19:37:34 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-22 19:38:18 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/78406baf2210d015caa04c59918e77142a487193
Cr-Commit-Position: refs/heads/master@{#339937}

Powered by Google App Engine
This is Rietveld 408576698