Presweep one page before parallel/concurrent sweeping.

Presweep one page before parallel/concurrent sweeping.


BUG=

Committed: https://code.google.com/p/v8/source/detail?r=13832

[Michael Starzinger, 2013-03-05 15:35:20]

https://codereview.chromium.org/12444003/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):

https://codereview.chromium.org/12444003/diff/1/src/mark-compact.cc#newcode3849
src/mark-compact.cc:3849: if (presweep) {
Can we use a "parallel_sweeping_flag" instead, to be in sync with lazy sweeping?
Also can you change to pre-sweeping during lazy-sweeping to have the same
pattern (i.e. move block into the switch)?

[Hannes Payer (out of office), 2013-03-05 17:22:48]

https://codereview.chromium.org/12444003/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):

https://codereview.chromium.org/12444003/diff/1/src/mark-compact.cc#newcode3849
src/mark-compact.cc:3849: if (presweep) {
On 2013/03/05 15:35:20, Michael Starzinger wrote:
> Can we use a "parallel_sweeping_flag" instead, to be in sync with lazy
sweeping?
> Also can you change to pre-sweeping during lazy-sweeping to have the same
> pattern (i.e. move block into the switch)?

Done.

[Michael Starzinger, 2013-03-05 17:46:33]

LGTM with one final comment.

https://codereview.chromium.org/12444003/diff/5001/src/mark-compact.cc
File src/mark-compact.cc (right):

https://codereview.chromium.org/12444003/diff/5001/src/mark-compact.cc#newcod...
src/mark-compact.cc:3835: freed_bytes +=
SweepConservatively<SWEEP_SEQUENTIALLY>(space, NULL, p);
Longer than 80 characters. Also the free_bytes counter is actually not needed
anymore, let's drop it.

[Hannes Payer (out of office), 2013-03-05 17:48:38]

https://codereview.chromium.org/12444003/diff/5001/src/mark-compact.cc
File src/mark-compact.cc (right):

https://codereview.chromium.org/12444003/diff/5001/src/mark-compact.cc#newcod...
src/mark-compact.cc:3835: freed_bytes +=
SweepConservatively<SWEEP_SEQUENTIALLY>(space, NULL, p);
On 2013/03/05 17:46:33, Michael Starzinger wrote:
> Longer than 80 characters. Also the free_bytes counter is actually not needed
> anymore, let's drop it.

Already done.

[Hannes Payer (out of office), 2013-03-05 17:51:54]

Committed patchset #3 manually as r13832 (presubmit successful).