src/heap/spaces.cc - Issue 1244353002: Use a lock in pages to synchronize sweeper threads to allow others to wait on concurrently swept pa…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/spaces.cc

Issue 1244353002: Use a lock in pages to synchronize sweeper threads to allow others to wait on concurrently swept pa… (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap/spaces.cc

diff --git a/src/heap/spaces.cc b/src/heap/spaces.cc

index dfaac73ffd10a4c7722a4ebd70d33bb8aa7d063a..e5d3270dd6204b11d992110121a304c8b8569376 100644

--- a/src/heap/spaces.cc

+++ b/src/heap/spaces.cc

@@ -499,6 +499,7 @@ MemoryChunk* MemoryChunk::Initialize(Heap* heap, Address base, size_t size,

chunk->progress_bar_ = 0;

chunk->high_water_mark_ = static_cast<int>(area_start - base);

chunk->set_parallel_sweeping(SWEEPING_DONE);

+ chunk->mutex_ = NULL;

chunk->available_in_small_free_list_ = 0;

chunk->available_in_medium_free_list_ = 0;

chunk->available_in_large_free_list_ = 0;

@@ -765,6 +766,7 @@ void MemoryAllocator::Free(MemoryChunk* chunk) {

delete chunk->slots_buffer();

delete chunk->skip_list();

+ delete chunk->mutex();

base::VirtualMemory* reservation = chunk->reserved_memory();

if (reservation->IsReserved()) {

« no previous file with comments | « src/heap/spaces.h ('k') | src/heap/spaces-inl.h » ('j') | no next file with comments »