Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1244343002: Revert of New thin layer of API extension chrome.i18n.detectLanguage (patchset #11 id:300001 of htt… (Closed)

Created:
5 years, 5 months ago by Matt Giuca
Modified:
5 years, 5 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of New thin layer of API extension chrome.i18n.detectLanguage (patchset #11 id:300001 of https://codereview.chromium.org/1208993011) Reason for revert: Suspect that this increased the size of chrome.dll on Windows by 1.63 MB (4%). Proactively reverting. Original issue's description: > New thin layer of API extension chrome.i18n.detectLanguage > > R=kalman@chromium.org, toyoshim@chromium.org > BUG= > > Review URL: https://codereview.chromium.org/1208993011 > > Cr-Commit-Position: refs/heads/master@{#339819} TBR=amalika@google.com,toyoshim@chromium.org,kalman@chromium.org,asvitkine@chromium.org,rockot@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=512666 Committed: https://crrev.com/01176aed17cd048af9c66f7d7d116fbde119201a Cr-Commit-Position: refs/heads/master@{#339837}

Patch Set 1 #

Patch Set 2 : Do revert histograms.xml. Apparently it is OK if it's only been a few hours. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -183 lines) Patch
M chrome/browser/extensions/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/api_registration.gyp View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/i18n/i18n_api.h View 2 chunks +0 lines, -25 lines 0 comments Download
M chrome/browser/extensions/api/i18n/i18n_api.cc View 2 chunks +5 lines, -88 lines 0 comments Download
M chrome/common/extensions/api/i18n.json View 3 chunks +3 lines, -58 lines 0 comments Download
M extensions/browser/extension_function_histogram_value.h View 1 chunk +0 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1244343002/20001
5 years, 5 months ago (2015-07-22 05:15:56 UTC) #2
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-22 05:16:39 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-07-22 05:17:20 UTC) #4
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/01176aed17cd048af9c66f7d7d116fbde119201a
Cr-Commit-Position: refs/heads/master@{#339837}

Powered by Google App Engine
This is Rietveld 408576698