content/renderer/media/webmediaplayer_proxy_impl_android.h - Issue 12443003: Implement out-of-band video compositing on Android: Step 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webmediaplayer_proxy_impl_android.h

Issue 12443003: Implement out-of-band video compositing on Android: Step 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nit2 Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/android/media_player_manager_android.h ('K') | « content/public/android/java/src/org/chromium/content/browser/ExternalVideoSurfaceViewHolder.java ('k') | content/renderer/media/webmediaplayer_proxy_impl_android.cc » ('j') | webkit/media/android/webmediaplayer_android.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/webmediaplayer_proxy_impl_android.h

diff --git a/content/renderer/media/webmediaplayer_proxy_impl_android.h b/content/renderer/media/webmediaplayer_proxy_impl_android.h

index e5e75db02e6daf3465223d3587e691a34b632221..cf35e223daef1aab3161ea6a964b0807f5045555 100644

--- a/content/renderer/media/webmediaplayer_proxy_impl_android.h

+++ b/content/renderer/media/webmediaplayer_proxy_impl_android.h

@@ -44,6 +44,7 @@ class WebMediaPlayerProxyImplAndroid

virtual void DestroyPlayer(int player_id) OVERRIDE;

virtual void EnterFullscreen(int player_id) OVERRIDE;

virtual void ExitFullscreen(int player_id) OVERRIDE;

+ virtual void RequestExternalSurface(int player_id) OVERRIDE;

private:

webkit_media::WebMediaPlayerImplAndroid* GetWebMediaPlayer(int player_id);