media/base/media_switches.cc - Issue 12443003: Implement out-of-band video compositing on Android: Step 1

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: media/base/media_switches.cc

Issue 12443003: Implement out-of-band video compositing on Android: Step 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/public/android/java/src/org/chromium/content/browser/ContentView.java ('K') | « media/base/media_switches.h ('k') | webkit/media/android/webmediaplayer_android.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "media/base/media_switches.h"	5 #include "media/base/media_switches.h"

6	6

7 namespace switches {	7 namespace switches {

8	8

9 // Allow users to specify a custom buffer size for debugging purpose.	9 // Allow users to specify a custom buffer size for debugging purpose.

10 const char kAudioBufferSize[] = "audio-buffer-size";	10 const char kAudioBufferSize[] = "audio-buffer-size";

(...skipping 48 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
59 // Enables Opus playback in media elements.	59 // Enables Opus playback in media elements.

60 const char kEnableOpusPlayback[] = "enable-opus-playback";	60 const char kEnableOpusPlayback[] = "enable-opus-playback";

61	61

62 // Enables VP9 playback in media elements.	62 // Enables VP9 playback in media elements.

63 const char kEnableVp9Playback[] = "enable-vp9-playback";	63 const char kEnableVp9Playback[] = "enable-vp9-playback";

64	64

65 #if defined(OS_WIN)	65 #if defined(OS_WIN)

66 const char kWaveOutBuffers[] = "waveout-buffers";	66 const char kWaveOutBuffers[] = "waveout-buffers";

67 #endif	67 #endif

68	68

	69 #if defined(OS_ANDROID)

	70 // Always use external video surface. Normally, external video surfaces are used

	71 // sparingly.

	72 const char kUseExternalVideoSurface[] = "use-external-video-surface";
	scherkus (not reviewing) 2013/03/07 18:59:11 sorry for not spotting this earlier, but this swit sorry for not spotting this earlier, but this switch should be defined closer to where it's actually used (nothing inside src/media/ inspects this switch). can you create webkit/media/media_switches.{cc,h} and place the switch there? wonsik 2013/03/11 12:32:44 Done. Show quoted text On 2013/03/07 18:59:11, scherkus wrote: > sorry for not spotting this earlier, but this switch should be defined closer to > where it's actually used (nothing inside src/media/ inspects this switch). > > can you create webkit/media/media_switches.{cc,h} and place the switch there? Done.
	73 #endif

	74

69 } // namespace switches	75 } // namespace switches

OLD	NEW