Implement out-of-band video compositing on Android: Step 1

content/public/android/java/src/org/chromium/content/browser/ContentView.java

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.content.browser;
 
 import android.app.Activity;
 import android.content.Context;
 import android.content.res.Configuration;
 import android.graphics.Bitmap;
 import android.graphics.Canvas;
 import android.graphics.Rect;
 import android.os.Build;
 import android.util.AttributeSet;
 import android.view.KeyEvent;
 import android.view.MotionEvent;
 import android.view.View;
+import android.view.SurfaceHolder;
+import android.view.SurfaceView;
 import android.view.accessibility.AccessibilityEvent;
 import android.view.accessibility.AccessibilityNodeInfo;
 import android.view.inputmethod.EditorInfo;
 import android.view.inputmethod.InputConnection;
 import android.widget.FrameLayout;
 
 import com.google.common.annotations.VisibleForTesting;
 
 import org.chromium.content.common.ProcessInitException;
 import org.chromium.content.common.TraceEvent;
@@ skipping 68 matching lines @@
             NativeWindow nativeWindow, AttributeSet attrs, int defStyle, int personality) {
         if (Build.VERSION.SDK_INT < Build.VERSION_CODES.JELLY_BEAN) {
             return new ContentView(context, nativeWebContents, nativeWindow, attrs, defStyle,
                     personality);
         } else {
             return new JellyBeanContentView(context, nativeWebContents, nativeWindow, attrs,
                     defStyle, personality);
         }
     }
 
+    private SurfaceView mExternalVideoSurfaceView;
+
     protected ContentView(Context context, int nativeWebContents, NativeWindow nativeWindow,
             AttributeSet attrs, int defStyle, int personality) {
         super(context, attrs, defStyle);
 
         mContentViewCore = new ContentViewCore(context, personality);
         mContentViewCore.initialize(this, this, nativeWebContents, nativeWindow, false);
+
+        mExternalVideoSurfaceView = new SurfaceView(getContext());
+        mExternalVideoSurfaceView.getHolder().addCallback(new SurfaceHolder.Callback() {
+            @Override
+            public void surfaceChanged(SurfaceHolder holder, int format, int width, int height) {
+            }
+
+            @Override
+            public void surfaceCreated(SurfaceHolder holder) {
+                mContentViewCore.externalVideoSurfaceCreated(holder.getSurface());
+            }
+
+            @Override
+            public void surfaceDestroyed(SurfaceHolder holder) {
+                mContentViewCore.externalVideoSurfaceDestroyed(holder.getSurface());
+            }
+        });
+
+        addView(mExternalVideoSurfaceView,
+                new FrameLayout.LayoutParams(
+                        FrameLayout.LayoutParams.MATCH_PARENT,
+                        FrameLayout.LayoutParams.MATCH_PARENT));
+        mExternalVideoSurfaceView.setZOrderMediaOverlay(false);

[no sievers, 2013/03/07 19:14:07]

I think this should all move to the app/embedder. Then you don't need a hook
back and forth either. What do you think?
(i.e. simply remove the changes to this file from the patch)

Also you might want to only create one SurfaceView for video (and not one per
tab), and move/resize it as needed when switching tabs.

In that case, I think renaming externalVideoSurfaceCreated/Destroyed() to
attach/detachExternalVideoSurface() might also be more fitting as in that it
expressed that you are redirecting the output.

[wonsik, 2013/03/11 12:32:44]

Could you point me to a starting point to investigate? I think I need some hint
here...

[no sievers, 2013/03/11 17:26:28]

I mean this code to create the external SurfaceView does not have to be in
content/, just like the main SurfaceView is not getting created from here.
The application can create the external video surface (on demand) and then use
the ChromeView API to redirect the video output to that.

[wonsik, 2013/03/14 06:28:14]

Created ExternalVideoSurfaceViewHolder to be injected from app or embedder.
Please review my approach and let me know if I can do better. Thanks!

     }
 
     /**
      * @return The core component of the ContentView that handles JNI communication.  Should only be
      *         used for passing to native.
      */
     public ContentViewCore getContentViewCore() {
         return mContentViewCore;
     }
 
@@ skipping 696 matching lines @@
 
     @Override
     public boolean super_awakenScrollBars(int startDelay, boolean invalidate) {
         return super.awakenScrollBars(startDelay, invalidate);
     }
 
     ///////////////////////////////////////////////////////////////////////////////////////////////
     //                End Implementation of ContentViewCore.InternalAccessDelegate               //
     ///////////////////////////////////////////////////////////////////////////////////////////////
 }