Implement out-of-band video compositing on Android: Step 1

content/browser/android/content_view_core_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/android/content_view_core_impl.h"
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_array.h"
 #include "base/android/jni_string.h"
 #include "base/android/scoped_java_ref.h"
 #include "base/command_line.h"
 #include "base/json/json_writer.h"
 #include "base/logging.h"
 #include "base/utf_string_conversions.h"
 #include "base/values.h"
 #include "cc/layer.h"
 #include "content/browser/android/interstitial_page_delegate_android.h"
 #include "content/browser/android/load_url_params.h"
+#include "content/browser/android/media_player_manager_android.h"
 #include "content/browser/android/touch_point.h"
 #include "content/browser/renderer_host/java/java_bound_object.h"
 #include "content/browser/renderer_host/java/java_bridge_dispatcher_host_manager.h"
 #include "content/browser/renderer_host/compositor_impl_android.h"
 #include "content/browser/renderer_host/render_view_host_impl.h"
 #include "content/browser/renderer_host/render_widget_host_impl.h"
 #include "content/browser/renderer_host/render_widget_host_view_android.h"
 #include "content/browser/ssl/ssl_host_state.h"
 #include "content/browser/web_contents/interstitial_page_impl.h"
 #include "content/browser/web_contents/navigation_controller_impl.h"
@@ skipping 1162 matching lines @@
                                                   bool enable) {
   RenderViewHost* host = web_contents_->GetRenderViewHost();
   host->Send(new ViewMsg_EnableHidingTopControls(host->GetRoutingID(), enable));
 }
 
 void ContentViewCoreImpl::ShowImeIfNeeded(JNIEnv* env, jobject obj) {
   RenderViewHost* host = web_contents_->GetRenderViewHost();
   host->Send(new ViewMsg_ShowImeIfNeeded(host->GetRoutingID()));
 }
 
+void ContentViewCoreImpl::ExternalVideoSurfaceCreated(JNIEnv* env,
+                                                      jobject obj,
+                                                      jobject jsurface) {
+  RenderViewHostImpl* rvhi = static_cast<RenderViewHostImpl*>(
+      web_contents_->GetRenderViewHost());
+  DCHECK(rvhi);

[scherkus (not reviewing), 2013/03/07 00:09:13]

DCHECKs aren't useful when you immediately dereference them

[wonsik, 2013/03/07 02:54:08]

Removed & added the condition in if clause.

+  if (rvhi->media_player_manager())
+    rvhi->media_player_manager()->SetExternalVideoSurface(jsurface);
+}
+
+void ContentViewCoreImpl::ExternalVideoSurfaceDestroyed(JNIEnv* env,
+                                                        jobject obj) {
+  RenderViewHostImpl* rvhi = static_cast<RenderViewHostImpl*>(
+      web_contents_->GetRenderViewHost());
+  DCHECK(rvhi);

[scherkus (not reviewing), 2013/03/07 00:09:13]

ditto

[wonsik, 2013/03/07 02:54:08]

Removed & added the condition in if clause.

+  if (rvhi->media_player_manager())
+    rvhi->media_player_manager()->SetExternalVideoSurface(NULL);
+}
+
 void ContentViewCoreImpl::ScrollFocusedEditableNodeIntoView(JNIEnv* env,
                                                             jobject obj) {
   RenderViewHost* host = web_contents_->GetRenderViewHost();
   host->Send(new ViewMsg_ScrollFocusedEditableNodeIntoRect(host->GetRoutingID(),
                                                            gfx::Rect()));
 }
 
 namespace {
 
 static void AddNavigationEntryToHistory(JNIEnv* env, jobject obj,
@@ skipping 207 matching lines @@
   if (!HasField(env, clazz, "mNativeContentViewCore", "I")) {
     DLOG(ERROR) << "Unable to find ContentView.mNativeContentViewCore!";
     return false;
   }
   g_native_content_view = GetFieldID(env, clazz, "mNativeContentViewCore", "I");
 
   return RegisterNativesImpl(env) >= 0;
 }
 
 }  // namespace content