Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1244243003: Revert of Call EnsureWebKitInitialized() before registering extensions (Closed)

Created:
5 years, 5 months ago by bashi
Modified:
5 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Call EnsureWebKitInitialized() before registering extensions (patchset #3 id:40001 of https://codereview.chromium.org/1182083006/) Reason for revert: This seems the cause of many crashes Original issue's description: > Call EnsureWebKitInitialized() before registering extensions > > Blink needs to be initialized before registering an extension because: > - WebScriptController::registerExtension() allocates an WTF::Vector on the first > call. > - WTF::Vector uses PartitionAlloc. > - PartitionAlloc's partitions needs to be initialized before allocating memory. > Blink initialization does the job. > > Before this CL, partitions are initialized lazily but lazy initialization > doesn't provide proper histogram function, which might be the cause of missing > report for PartitionAlloc.CommittedSize UMA. > > BUG=501171 > > Committed: https://crrev.com/0d244fa5e106b3d146655a2c623539a3e1900831 > Cr-Commit-Position: refs/heads/master@{#339200} TBR=jochen@chromium.org,haraken@chromium.org,kalman@chromium.org,kinuko@chromium.org,paulmeyer@chromium.org,sievers@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=501171 Committed: https://crrev.com/2b94b05fc252c9a006ae924d0fe75ed3abecbeb2 Cr-Commit-Position: refs/heads/master@{#339777}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M chrome/renderer/chrome_content_renderer_client.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/renderer/dispatcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bashi
Created Revert of Call EnsureWebKitInitialized() before registering extensions
5 years, 5 months ago (2015-07-21 23:25:39 UTC) #1
haraken
LGTM
5 years, 5 months ago (2015-07-21 23:26:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1244243003/1
5 years, 5 months ago (2015-07-21 23:26:38 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-21 23:28:14 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2b94b05fc252c9a006ae924d0fe75ed3abecbeb2 Cr-Commit-Position: refs/heads/master@{#339777}
5 years, 5 months ago (2015-07-21 23:29:15 UTC) #5
bashi
5 years, 4 months ago (2015-07-28 00:42:05 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1258103005/ by bashi@chromium.org.

The reason for reverting is: It turns out this CL isn't the culprit of crashes.
Let's revert the revert..

Powered by Google App Engine
This is Rietveld 408576698