Minor Ash panel related cleanup

Minor Ash panel related cleanup

A little code cleanup I did while debugging some panel focus issues.

BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192575

[stevenjb, 2013-03-21 02:45:24]

Feel free to push back if you don't like the change, but it seemed like the
Panel test really ought to be in the caller not the callee for
MoveToEventRoot().

[oshima, 2013-03-21 04:21:25]

I did this way because I felt this is less error prone,
especially there is no other use case. I'm fine if you
prefer this way though.

One question if I may ask, is that MoveToEventRoot now
looks generic function, and having it in launcher_util.h
looks odd. Is there better place?

[stevenjb (google-dont-use), 2013-03-21 18:11:14]

You tell me :) RootWindow?




On Wed, Mar 20, 2013 at 9:21 PM, <oshima@chromium.org> wrote:

> I did this way because I felt this is less error prone,
> especially there is no other use case. I'm fine if you
> prefer this way though.
>
> One question if I may ask, is that MoveToEventRoot now
> looks generic function, and having it in launcher_util.h
> looks odd. Is there better place?
>
>
>
https://codereview.chromium.**org/12442009/<https://codereview.chromium.org/1...
>

[oshima, 2013-03-21 18:14:43]

On 2013/03/21 18:11:14, stevenjb1 wrote:
> You tell me :) RootWindow?
> 

how about ash/wm/window_util.h ?


> 
> 
> 
> On Wed, Mar 20, 2013 at 9:21 PM, <mailto:oshima@chromium.org> wrote:
> 
> > I did this way because I felt this is less error prone,
> > especially there is no other use case. I'm fine if you
> > prefer this way though.
> >
> > One question if I may ask, is that MoveToEventRoot now
> > looks generic function, and having it in launcher_util.h
> > looks odd. Is there better place?
> >
> >
> >
>
https://codereview.chromium.**org/12442009/%3Chttps://codereview.chromium.org...>
> >

[stevenjb, 2013-03-25 17:58:19]

On 2013/03/21 18:14:43, oshima wrote:
> On 2013/03/21 18:11:14, stevenjb1 wrote:
> > You tell me :) RootWindow?
> > 
> 
> how about ash/wm/window_util.h ?
> 

Done.

[oshima, 2013-03-25 18:11:52]

lgtm

[stevenjb, 2013-04-04 23:31:38]

+ben for OWNER

[Ben Goodger (Google), 2013-04-05 02:01:13]

lgtm


On Thu, Apr 4, 2013 at 4:31 PM, <stevenjb@chromium.org> wrote:

> +ben for OWNER
>
>
>
https://chromiumcodereview.**appspot.com/12442009/<https://chromiumcodereview...
>

[stevenjb, 2013-04-05 16:16:13]

Committed patchset #4 manually as r192575 (presubmit successful).