Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: pkg/unittest/lib/src/test_case.dart

Issue 12442005: pkg/unittest: fix TestCase.runningTime (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/unittest/lib/src/test_case.dart
===================================================================
--- pkg/unittest/lib/src/test_case.dart (revision 19519)
+++ pkg/unittest/lib/src/test_case.dart (working copy)
@@ -120,7 +120,7 @@
// Calling error() will result in the tearDown being done.
// One could debate whether tearDown should be done after
// a failed setUp. There is no right answer, but doing it
- // seems to be the more conservative approach, because
+ // seems to be the more conservative approach, because
// unittest will not stop at a test failure.
error("$description: Test setup failed: ${e.error}");
});
@@ -162,10 +162,7 @@
[String messageText = '',
String stack = '']) {
if (runningTime == null) {
- // TODO(gram): currently the duration measurement code is blocked
- // by issue 4437. When that is fixed replace the line below with:
- // runningTime = new DateTime.now().difference(startTime);
- runningTime = new Duration(milliseconds: 0);
+ runningTime = new DateTime.now().difference(startTime);
}
_setResult(testResult, messageText, stack);
if (!_doneTeardown) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698