Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1244173005: Compile with VS2015. (Closed)

Created:
5 years, 5 months ago by bungeman-skia
Modified:
5 years, 5 months ago
Reviewers:
bsalomon, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Compile with VS2015. Visual Studio 2015 has additional warnings around noexcept and disabling exceptions, which can be worked around with the (undocumented) _HAS_EXCEPTIONS macro. Visual Studio 2013 and 2015 have roundf in math.h, so use it to avoid extra work and casts. We avoid using cmath, as it undefs isfinite on gcc, but Visual Studio 2015 no longer provides overloads of copysign from math.h (which is actually correct). As a result, use copysignf (which is available in math.h in 2013 and 2015) directly. Committed: https://skia.googlesource.com/skia/+/b7069e9c1f65d11f9581be0adbffa968257afc33

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M gyp/common_conditions.gypi View 1 chunk +1 line, -0 lines 1 comment Download
M include/core/SkFloatingPoint.h View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleRegion.cpp View 3 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1244173005/1
5 years, 5 months ago (2015-07-21 20:57:58 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-21 21:05:14 UTC) #4
bungeman-skia
I went and installed Visual Studio 2015 to see what the damage is. Isn't all ...
5 years, 5 months ago (2015-07-21 21:07:28 UTC) #6
mtklein
lgtm
5 years, 5 months ago (2015-07-21 21:10:38 UTC) #7
bsalomon
lgtm
5 years, 5 months ago (2015-07-21 21:11:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1244173005/1
5 years, 5 months ago (2015-07-21 21:13:57 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 21:14:33 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b7069e9c1f65d11f9581be0adbffa968257afc33

Powered by Google App Engine
This is Rietveld 408576698