Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 1244163004: Update WebGL CTS 1 expected failures. (Closed)

Created:
5 years, 5 months ago by Jamie Madill
Modified:
5 years, 5 months ago
Reviewers:
Zhenyao Mo, bajones
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update WebGL CTS 1 expected failures. Several bugs were fixed in the ANGLE translator that should make these tests pass on all platforms. BUG=478572, 485632 Committed: https://crrev.com/22e1540c55e0899dec25901626481630e9a224fb Cr-Commit-Position: refs/heads/master@{#340138}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M content/test/gpu/gpu_tests/webgl_conformance_expectations.py View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Jamie Madill
Mo/Brandon, PTAL. Failures look unrelated so far.
5 years, 5 months ago (2015-07-23 16:07:48 UTC) #2
Zhenyao Mo
On 2015/07/23 16:07:48, Jamie Madill wrote: > Mo/Brandon, PTAL. Failures look unrelated so far. Great! ...
5 years, 5 months ago (2015-07-23 17:32:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1244163004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1244163004/1
5 years, 5 months ago (2015-07-23 17:34:19 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/42033)
5 years, 5 months ago (2015-07-23 18:17:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1244163004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1244163004/1
5 years, 5 months ago (2015-07-23 18:51:37 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-23 19:21:41 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/22e1540c55e0899dec25901626481630e9a224fb Cr-Commit-Position: refs/heads/master@{#340138}
5 years, 5 months ago (2015-07-23 19:22:47 UTC) #11
Geoff Lang
5 years, 5 months ago (2015-07-23 23:30:14 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1244343003/ by geofflang@chromium.org.

The reason for reverting is: Causing failures on the webgl_gl_tests on the FYI
tests.  We'll need to update the expectations while leaving some suppressions
for those bots.

Example failure:
http://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Release%20%28ATI....

Powered by Google App Engine
This is Rietveld 408576698