Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 1244143004: Remove test of illegal behavior that modifies a texture backing an SkImage. (Closed)

Created:
5 years, 5 months ago by bsalomon
Modified:
5 years, 5 months ago
Reviewers:
reed2, robertphillips
CC:
reviews_skia.org, reed1
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove test of illegal behavior that modifies a texture backing an SkImage. Committed: https://skia.googlesource.com/skia/+/a449779a330123062e752228de8e3f84593a6fd1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M include/core/SkImage.h View 1 chunk +1 line, -1 line 0 comments Download
M tests/SurfaceTest.cpp View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
bsalomon
5 years, 5 months ago (2015-07-23 19:14:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1244143004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1244143004/1
5 years, 5 months ago (2015-07-23 19:14:33 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 5 months ago (2015-07-23 19:14:33 UTC) #5
robertphillips
lgtm
5 years, 5 months ago (2015-07-23 19:17:10 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/a449779a330123062e752228de8e3f84593a6fd1
5 years, 5 months ago (2015-07-23 19:22:21 UTC) #7
reed2
5 years, 5 months ago (2015-07-24 00:36:15 UTC) #9
Message was sent while issue was closed.
good! more restrictions!

Powered by Google App Engine
This is Rietveld 408576698