Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Side by Side Diff: LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js

Issue 1244123003: The type argument for HTMLCanvasElement toDataURL() api should not be nullable (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 description( 1 description(
2 'This tests the behavior of non-numeric values in contexts where the DOM has a n umeric parameter.' 2 'This tests the behavior of non-numeric values in contexts where the DOM has a n umeric parameter.'
3 ); 3 );
4 4
5 function nonNumericPolicy(template) 5 function nonNumericPolicy(template)
6 { 6 {
7 var x = 0; 7 var x = 0;
8 try { 8 try {
9 eval(template); 9 eval(template);
10 } catch (e) { 10 } catch (e) {
(...skipping 244 matching lines...) Expand 10 before | Expand all | Expand 10 after
255 shouldBe("nonNumericPolicy('createHTMLTableSectionElement().insertRow(x)')", "'a ny type allowed'"); 255 shouldBe("nonNumericPolicy('createHTMLTableSectionElement().insertRow(x)')", "'a ny type allowed'");
256 shouldBe("nonNumericPolicy('createHTMLTableSectionElement().deleteRow(x)')", "'a ny type allowed (but not omitted)'"); 256 shouldBe("nonNumericPolicy('createHTMLTableSectionElement().deleteRow(x)')", "'a ny type allowed (but not omitted)'");
257 257
258 // HTMLInputElement 258 // HTMLInputElement
259 259
260 shouldBe("nonNumericPolicy('document.createElement(\"textarea\").setSelectionRan ge(x, 0)')", "'any type allowed'"); 260 shouldBe("nonNumericPolicy('document.createElement(\"textarea\").setSelectionRan ge(x, 0)')", "'any type allowed'");
261 shouldBe("nonNumericPolicy('document.createElement(\"textarea\").setSelectionRan ge(0, x)')", "'any type allowed'"); 261 shouldBe("nonNumericPolicy('document.createElement(\"textarea\").setSelectionRan ge(0, x)')", "'any type allowed'");
262 262
263 // HTMLCanvasElement 263 // HTMLCanvasElement
264 264
265 shouldBe("nonNumericPolicy('createCanvasElement().toDataURL(x)')", "'any type al lowed'");
philipj_slow 2015/07/23 08:02:12 Would this have failed before your change? I don't
shiva.jm 2015/07/23 08:33:40 Done.
265 shouldBe("nonNumericPolicy('createCanvasElement().getContext(x)')", "'any type a llowed (but not omitted)'"); 266 shouldBe("nonNumericPolicy('createCanvasElement().getContext(x)')", "'any type a llowed (but not omitted)'");
266 267
267 // KeyboardEvent 268 // KeyboardEvent
268 269
269 shouldBe("nonNumericPolicy('document.createEvent(\"KeyboardEvent\").initKeyboard Event(\"a\", false, false, null, \"b\", x, false, false, false, false, false)')" , "'any type allowed'"); 270 shouldBe("nonNumericPolicy('document.createEvent(\"KeyboardEvent\").initKeyboard Event(\"a\", false, false, null, \"b\", x, false, false, false, false, false)')" , "'any type allowed'");
270 271
271 // MediaList 272 // MediaList
272 273
273 shouldBe("nonNumericPolicy('createMediaList().item(x)')", "'any type allowed (bu t not omitted)'"); 274 shouldBe("nonNumericPolicy('createMediaList().item(x)')", "'any type allowed (bu t not omitted)'");
274 275
(...skipping 356 matching lines...) Expand 10 before | Expand all | Expand 10 after
631 ../../../../WebCore/svg/SVGSVGElement.idl: attribute float curre ntScale 632 ../../../../WebCore/svg/SVGSVGElement.idl: attribute float curre ntScale
632 633
633 ../../../../WebCore/svg/SVGMatrix.idl: attribute double a; 634 ../../../../WebCore/svg/SVGMatrix.idl: attribute double a;
634 ../../../../WebCore/svg/SVGMatrix.idl: attribute double b; 635 ../../../../WebCore/svg/SVGMatrix.idl: attribute double b;
635 ../../../../WebCore/svg/SVGMatrix.idl: attribute double c; 636 ../../../../WebCore/svg/SVGMatrix.idl: attribute double c;
636 ../../../../WebCore/svg/SVGMatrix.idl: attribute double d; 637 ../../../../WebCore/svg/SVGMatrix.idl: attribute double d;
637 ../../../../WebCore/svg/SVGMatrix.idl: attribute double e; 638 ../../../../WebCore/svg/SVGMatrix.idl: attribute double e;
638 ../../../../WebCore/svg/SVGMatrix.idl: attribute double f; 639 ../../../../WebCore/svg/SVGMatrix.idl: attribute double f;
639 640
640 */ 641 */
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698