tools/testing/dart/multitest.dart - Issue 12441003: Rename String.concat to operator+.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testing/dart/multitest.dart

Issue 12441003: Rename String.concat to operator+. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/testing/dart/multitest.dart

diff --git a/tools/testing/dart/multitest.dart b/tools/testing/dart/multitest.dart

index 585502c298e26c49677de6412a03d113da8f2fd9..b9596bfc5f47aaea68242ba0f717e7985d02da39 100644

--- a/tools/testing/dart/multitest.dart

+++ b/tools/testing/dart/multitest.dart

@@ -122,7 +122,7 @@ void ExtractTestsFromMultitest(Path filePath,

// Copy all the tests into the output map tests, as multiline strings.

for (String key in testsAsLines.keys) {

- tests[key] = testsAsLines[key].join(line_separator).concat(line_separator);

+ tests[key] = testsAsLines[key].join(line_separator) + line_separator;

floitsch 2013/03/08 23:46:48 Are you sure this works already now? Usually tools

Lasse Reichstein Nielsen 2013/03/12 11:43:12 Ack, will revert. Apparently this isn't hit throug

}