Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1244093004: Remove some fields from BitmapTextBatch (Closed)

Created:
5 years, 5 months ago by bsalomon
Modified:
5 years, 5 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove some redundant fields from BitmapTextBatch (and rename to TextBatch). Committed: https://skia.googlesource.com/skia/+/265697d91b66679a0b28cfa06dd36e78c5bd6adc

Patch Set 1 #

Patch Set 2 : stuff #

Patch Set 3 : set back to 32 #

Patch Set 4 : minor #

Patch Set 5 : rebase #

Patch Set 6 : friendship #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -145 lines) Patch
M src/gpu/GrAtlasTextContext.h View 1 2 3 4 3 chunks +5 lines, -6 lines 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 1 2 3 4 19 chunks +131 lines, -124 lines 0 comments Download
M src/gpu/GrBatchFontCache.h View 1 chunk +11 lines, -2 lines 0 comments Download
M src/gpu/GrBatchFontCache.cpp View 2 chunks +1 line, -12 lines 0 comments Download
M src/gpu/GrTextContext.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
bsalomon
5 years, 5 months ago (2015-07-22 15:24:05 UTC) #2
joshualitt
On 2015/07/22 15:24:05, bsalomon wrote: lgtm
5 years, 5 months ago (2015-07-22 15:26:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1244093004/60001
5 years, 5 months ago (2015-07-22 15:37:47 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/2083) Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, ...
5 years, 5 months ago (2015-07-22 15:38:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1244093004/80001
5 years, 5 months ago (2015-07-22 16:50:12 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/2193)
5 years, 5 months ago (2015-07-22 16:51:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1244093004/100001
5 years, 5 months ago (2015-07-22 17:10:36 UTC) #15
commit-bot: I haz the power
5 years, 5 months ago (2015-07-22 17:17:29 UTC) #16
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/265697d91b66679a0b28cfa06dd36e78c5bd6adc

Powered by Google App Engine
This is Rietveld 408576698