Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 1244033005: Enable tab discarding on Mac (behind a flag). (Closed)

Created:
5 years, 5 months ago by Georges Khalil
Modified:
5 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, gab, chrisha
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable tab discarding on Mac (behind a flag). This enables tab discarding for Mac, hidden behind a command line flag (enable-tab-discarding). Linux to follow. Notes: - This doesn't invoke RecordMemoryStats yet as I'm working towards unifying GetSystemMemoryInfo across all desktop. - This is CL #9 towards expanding Chromeos tab discarding to other platforms. This enables it for Mac. BUG=463597 Committed: https://crrev.com/bf286e50cbd2f286fc33e9ece620405ffd17d07c Cr-Commit-Position: refs/heads/master@{#340266}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -19 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/browser_process_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_process_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/memory/oom_priority_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/about_ui.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/common/url_constants.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/url_constants.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
Georges Khalil
PTAL.
5 years, 5 months ago (2015-07-23 20:26:11 UTC) #3
sky
Is there a reason you don't want to enable on linux too?
5 years, 5 months ago (2015-07-23 22:58:31 UTC) #4
sky
I'm guessing the underlying measuring isn't that for linux. LGTM
5 years, 5 months ago (2015-07-23 22:59:18 UTC) #5
Georges Khalil
On 2015/07/23 22:59:18, sky wrote: > I'm guessing the underlying measuring isn't that for linux. ...
5 years, 5 months ago (2015-07-24 02:18:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1244033005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1244033005/20001
5 years, 5 months ago (2015-07-24 03:55:20 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/81672)
5 years, 5 months ago (2015-07-24 04:21:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1244033005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1244033005/20001
5 years, 5 months ago (2015-07-24 12:54:26 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 5 months ago (2015-07-24 12:59:55 UTC) #13
commit-bot: I haz the power
5 years, 5 months ago (2015-07-24 13:00:33 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf286e50cbd2f286fc33e9ece620405ffd17d07c
Cr-Commit-Position: refs/heads/master@{#340266}

Powered by Google App Engine
This is Rietveld 408576698