Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1132)

Issue 1244023002: [arm] Address TODO in CallConstructStub::Generate. (Closed)

Created:
5 years, 5 months ago by Michael Starzinger
Modified:
5 years, 5 months ago
Reviewers:
jbramley
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm] Address TODO in CallConstructStub::Generate. R=jacob.bramley@arm.com Committed: https://crrev.com/1b616a682f9ae4adb241612e6147023e55d3db2e Cr-Commit-Position: refs/heads/master@{#29774}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -26 lines) Patch
M src/arm/code-stubs-arm.cc View 7 chunks +23 lines, -26 lines 2 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
https://codereview.chromium.org/1244023002/diff/1/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): https://codereview.chromium.org/1244023002/diff/1/src/arm/code-stubs-arm.cc#newcode2398 src/arm/code-stubs-arm.cc:2398: __ Push(r4); Please don't make me implement the Push() ...
5 years, 5 months ago (2015-07-21 13:22:26 UTC) #2
jbramley
lgtm https://codereview.chromium.org/1244023002/diff/1/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): https://codereview.chromium.org/1244023002/diff/1/src/arm/code-stubs-arm.cc#newcode2398 src/arm/code-stubs-arm.cc:2398: __ Push(r4); On 2015/07/21 13:22:26, Michael Starzinger wrote: ...
5 years, 5 months ago (2015-07-21 13:28:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1244023002/1
5 years, 5 months ago (2015-07-21 13:54:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-21 14:13:22 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 14:13:45 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1b616a682f9ae4adb241612e6147023e55d3db2e
Cr-Commit-Position: refs/heads/master@{#29774}

Powered by Google App Engine
This is Rietveld 408576698