Issue 12440066: Fix minor valgrind-found memory leaks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12440066: Fix minor valgrind-found memory leaks (Closed)

Created:
7 years, 9 months ago by robertphillips

Modified:
7 years, 9 months ago

Reviewers:
bsalomon, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Patch Set 2 : Addressed code review issues #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -5 lines)			Patch
M	src/core/SkRefDict.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/effects/SkMatrixConvolutionImageFilter.cpp	View		2 chunks	+3 lines, -4 lines	0 comments	Download
M	tests/Matrix44Test.cpp	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/PDFPrimitivesTest.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

reed1

lgtm One suggestion to use template helper. https://codereview.chromium.org/12440066/diff/1/src/core/SkRefDict.cpp File src/core/SkRefDict.cpp (right): https://codereview.chromium.org/12440066/diff/1/src/core/SkRefDict.cpp#newcode62 src/core/SkRefDict.cpp:62: delete rec; ...

7 years, 9 months ago (2013-03-21 14:21:52 UTC) #3

robertphillips

7 years, 9 months ago (2013-03-21 17:40:21 UTC) #4

Message was sent while issue was closed.

committed as r8297

https://codereview.chromium.org/12440066/diff/1/src/core/SkRefDict.cpp
File src/core/SkRefDict.cpp (right):

https://codereview.chromium.org/12440066/diff/1/src/core/SkRefDict.cpp#newcode62
src/core/SkRefDict.cpp:62: delete rec;
Yes - this was found in the RefDict test.

Expand Messages | Collapse Messages

Issue 12440066: Fix minor valgrind-found memory leaks (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed code review issues #

Messages