src/runtime.cc - Issue 12440061: Improve SeqString::Truncate for latest allocated strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.cc

Issue 12440061: Improve SeqString::Truncate for latest allocated strings. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime.cc

diff --git a/src/runtime.cc b/src/runtime.cc

index b14cdbdfc3e5b2fa5bd5261bc36c4943da089f47..55555ab73a9d5dcce45036073987c1b608525886 100644

--- a/src/runtime.cc

+++ b/src/runtime.cc

@@ -5140,7 +5140,9 @@ RUNTIME_FUNCTION(MaybeObject*, Runtime_TruncateString) {

NoHandleAllocation ha(isolate);

CONVERT_ARG_CHECKED(SeqString, string, 0);

CONVERT_SMI_ARG_CHECKED(new_length, 1);

- return string->Truncate(new_length);

+ if (new_length == 0) return isolate->heap()->empty_string();

Hannes Payer (out of office) 2013/03/21 12:48:30 Again, this could be handled in Truncate().

+ string->Truncate(new_length);

+ return string;

}

« src/objects.cc ('K') | « src/objects.cc ('k') | src/spaces.h » ('j') | no next file with comments »