Issue 12440052: Reland r8235 "Switch gm to use SkFlags."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12440052: Reland r8235 "Switch gm to use SkFlags." (Closed)

Created:
7 years, 9 months ago by scroggo

Modified:
7 years, 9 months ago

Reviewers:

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Reland r8235 "Switch gm to use SkFlags." This time, using #if guards for gpuCacheSize consistently. Also fix some warnings. BUG=https://code.google.com/p/skia/issues/detail?id=1094 Committed: https://code.google.com/p/skia/source/detail?r=8254

Patch Set 1 #

Patch Set 2 : Rebase, and fix a warning. #

Patch Set 3 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+237 lines, -293 lines)			Patch
M	gm/gmmain.cpp	View	1 2	24 chunks	+147 lines, -260 lines	0 comments	Download
M	gm/tests/outputs/compared-against-different-pixels-images/output-expected/command_line	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gm/tests/outputs/compared-against-different-pixels-json/output-expected/command_line	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gm/tests/outputs/compared-against-empty-dir/output-expected/command_line	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gm/tests/outputs/compared-against-identical-bytes-images/output-expected/command_line	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gm/tests/outputs/compared-against-identical-bytes-json/output-expected/command_line	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gm/tests/outputs/compared-against-identical-pixels-images/output-expected/command_line	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gm/tests/outputs/compared-against-identical-pixels-json/output-expected/command_line	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gm/tests/outputs/no-readpath/output-expected/command_line	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gm/tests/run.sh	View		5 chunks	+5 lines, -5 lines	0 comments	Download
A	gyp/flags.gyp	View		1 chunk	+29 lines, -0 lines	0 comments	Download
M	gyp/gm.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	gyp/tools.gyp	View		4 chunks	+2 lines, -6 lines	0 comments	Download
M	tools/SkFlags.h	View		5 chunks	+39 lines, -12 lines	0 comments	Download
M	tools/SkFlags.cpp	View		1 chunk	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

scroggo

7 years, 9 months ago (2013-03-20 14:20:34 UTC) #1

Message was sent while issue was closed.

Committed patchset #3 manually as r8254 (presubmit successful).

Expand Messages | Collapse Messages