Issue 12440041: Generalizing remaining Allocate functions in the macro assemblers used in pretenuring.

Issue 12440041: Generalizing remaining Allocate functions in the macro assemblers used in pretenuring. (Closed)

Created:
7 years, 9 months ago by Hannes Payer (out of office)

Modified:
7 years, 9 months ago

Reviewers:
mvstanton, Michael Starzinger, danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Generalizing remaining Allocate functions in the macro assemblers used in pretenuring. BUG= Committed: https://code.google.com/p/v8/source/detail?r=14065

Patch Set 2 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+232 lines, -242 lines)			Patch
M	src/arm/builtins-arm.cc	View	1	3 chunks	+8 lines, -9 lines	0 comments	Download
M	src/arm/code-stubs-arm.cc	View	1	3 chunks	+4 lines, -9 lines	0 comments	Download
M	src/arm/codegen-arm.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	1	1 chunk	+6 lines, -6 lines	0 comments	Download
M	src/arm/macro-assembler-arm.h	View		1 chunk	+6 lines, -6 lines	0 comments	Download
	src/arm/macro-assembler-arm.cc	View		5 chunks	+26 lines, -26 lines	0 comments	Download
M	src/arm/stub-cache-arm.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/builtins-ia32.cc	View	1	3 chunks	+19 lines, -20 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	1	3 chunks	+11 lines, -11 lines	0 comments	Download
M	src/ia32/codegen-ia32.cc	View	1	2 chunks	+3 lines, -4 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/macro-assembler-ia32.h	View		1 chunk	+16 lines, -16 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.cc	View		9 chunks	+44 lines, -44 lines	0 comments	Download
M	src/x64/builtins-x64.cc	View	1	3 chunks	+22 lines, -22 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	1	3 chunks	+10 lines, -10 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/macro-assembler-x64.h	View		1 chunk	+14 lines, -14 lines	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View		6 chunks	+36 lines, -38 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

danno

lgtm with comments https://codereview.chromium.org/12440041/diff/1/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): https://codereview.chromium.org/12440041/diff/1/src/arm/code-stubs-arm.cc#newcode4959 src/arm/code-stubs-arm.cc:4959: __ Allocate(r1, nit: can you fix ...

7 years, 9 months ago (2013-03-20 22:11:09 UTC) #2

Hannes Payer (out of office)

Committed patchset #2 manually as r14065 (presubmit successful).

7 years, 9 months ago (2013-03-25 15:54:35 UTC) #3

Hannes Payer (out of office)

7 years, 9 months ago (2013-03-25 16:04:25 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/12440041/diff/1/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):

https://codereview.chromium.org/12440041/diff/1/src/arm/code-stubs-arm.cc#new...
src/arm/code-stubs-arm.cc:4959: __ Allocate(r1,
On 2013/03/20 22:11:09, danno wrote:
> nit: can you fix the formatting while you are here? multiple arguments per
line

Done.

https://codereview.chromium.org/12440041/diff/1/src/arm/code-stubs-arm.cc#new...
src/arm/code-stubs-arm.cc:4965: SIZE_IN_WORDS));
On 2013/03/20 22:11:09, danno wrote:
> Fits on one line

Done.

Expand Messages | Collapse Messages