Do not pass the string device_id via IPC message to create an audio input stream

media/base/audio_capturer_source.h

Index: media/base/audio_capturer_source.h
diff --git a/media/base/audio_capturer_source.h b/media/base/audio_capturer_source.h
index 2f99b926af564bf8ee3038ee1a711931dc82183a..ddcbbe317876f9edf08158f8e2e0794776982a02 100644
--- a/media/base/audio_capturer_source.h
+++ b/media/base/audio_capturer_source.h
@@ -35,25 +35,15 @@ class AudioCapturerSource
     virtual ~CaptureCallback() {}
   };
 
-  class CaptureEventHandler {
-   public:
-    // Notification to the client that the device with the specific |device_id|
-    // has been started.
-    virtual void OnDeviceStarted(const std::string& device_id) = 0;
-
-    // Notification to the client that the device has been stopped.
-    virtual void OnDeviceStopped() = 0;
-
-   protected:
-    virtual ~CaptureEventHandler() {}
-  };
-
   // Sets information about the audio stream format and the device
   // to be used. It must be called before any of the other methods.
-  // TODO(xians): Add |device_id| to this Initialize() function.
+  // The |session_id| is used by the browser to identify which input device to
+  // be used. For clients who does not care about device permission and device

[palmer, 2013/03/12 17:45:11]

Typo: does --> do

[no longer working on chromium, 2013/03/14 10:47:32]

Done.

+  // selection, pass |session_id| using a value of 1

[palmer, 2013/03/12 17:45:11]

Just document the named constant, not the magic number 1. Callers should not
rely on magic numbers.

[no longer working on chromium, 2013/03/14 10:47:32]

Done.

+  // (AudioInputDeviceManager::kFakeOpenSessionId).
   virtual void Initialize(const AudioParameters& params,
                           CaptureCallback* callback,
-                          CaptureEventHandler* event_handler) = 0;
+                          int session_id) = 0;
 
   // Starts the audio recording.
   virtual void Start() = 0;
@@ -65,10 +55,6 @@ class AudioCapturerSource
   // Sets the capture volume, with range [0.0, 1.0] inclusive.
   virtual void SetVolume(double volume) = 0;
 
-  // Specifies the |session_id| to query which device to use.
-  // TODO(xians): Change the interface to SetDevice(const std::string&).
-  virtual void SetDevice(int session_id) = 0;
-
   // Enables or disables the WebRtc AGC control.
   virtual void SetAutomaticGainControl(bool enable) = 0;