Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1520)

Unified Diff: content/renderer/media/audio_input_message_filter.cc

Issue 12440027: Do not pass the string device_id via IPC message to create an audio input stream (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ready for review Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/audio_input_message_filter.cc
diff --git a/content/renderer/media/audio_input_message_filter.cc b/content/renderer/media/audio_input_message_filter.cc
index 58dcc2ec7a06e789bec9d398a3f906e7f8fbad09..f9eb4b3079ff8b8ed8b10b30b2d21b7503af432c 100644
--- a/content/renderer/media/audio_input_message_filter.cc
+++ b/content/renderer/media/audio_input_message_filter.cc
@@ -49,8 +49,6 @@ bool AudioInputMessageFilter::OnMessageReceived(const IPC::Message& message) {
IPC_MESSAGE_HANDLER(AudioInputMsg_NotifyStreamVolume, OnStreamVolume)
IPC_MESSAGE_HANDLER(AudioInputMsg_NotifyStreamStateChanged,
OnStreamStateChanged)
- IPC_MESSAGE_HANDLER(AudioInputMsg_NotifyDeviceStarted,
- OnDeviceStarted)
IPC_MESSAGE_UNHANDLED(handled = false)
IPC_END_MESSAGE_MAP()
return handled;
@@ -135,17 +133,6 @@ void AudioInputMessageFilter::OnStreamStateChanged(
delegate->OnStateChanged(state);
}
-void AudioInputMessageFilter::OnDeviceStarted(int stream_id,
- const std::string& device_id) {
- DCHECK(io_message_loop_->BelongsToCurrentThread());
- media::AudioInputIPCDelegate* delegate = delegates_.Lookup(stream_id);
- if (!delegate) {
- NOTREACHED();
- return;
- }
- delegate->OnDeviceReady(device_id);
-}
-
int AudioInputMessageFilter::AddDelegate(
media::AudioInputIPCDelegate* delegate) {
DCHECK(io_message_loop_->BelongsToCurrentThread());
@@ -158,11 +145,11 @@ void AudioInputMessageFilter::RemoveDelegate(int id) {
}
void AudioInputMessageFilter::CreateStream(int stream_id,
+ int session_id,
const media::AudioParameters& params,
- const std::string& device_id,
bool automatic_gain_control) {
Send(new AudioInputHostMsg_CreateStream(
- stream_id, params, device_id, automatic_gain_control));
+ stream_id, session_id, params, automatic_gain_control));
}
void AudioInputMessageFilter::AssociateStreamWithConsumer(int stream_id,
@@ -171,10 +158,6 @@ void AudioInputMessageFilter::AssociateStreamWithConsumer(int stream_id,
stream_id, render_view_id));
}
-void AudioInputMessageFilter::StartDevice(int stream_id, int session_id) {
- Send(new AudioInputHostMsg_StartDevice(stream_id, session_id));
-}
-
void AudioInputMessageFilter::RecordStream(int stream_id) {
Send(new AudioInputHostMsg_RecordStream(stream_id));
}

Powered by Google App Engine
This is Rietveld 408576698