content/common/media/audio_messages.h - Issue 12440027: Do not pass the string device_id via IPC message to create an audio input stream

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/media/audio_messages.h

Issue 12440027: Do not pass the string device_id via IPC message to create an audio input stream (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: ready for review Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/media/audio_input_renderer_host.cc ('K') | « content/browser/renderer_host/media/media_stream_manager.cc ('k') | content/content_browser.gypi » ('j') | content/renderer/media/webrtc_audio_capturer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/media/audio_messages.h

diff --git a/content/common/media/audio_messages.h b/content/common/media/audio_messages.h

index 330a1b476ba4184f5f0e569472c08446ebc4ede6..b8da71ed43a58f405bfc02222ef16ede8b2eb36a 100644

--- a/content/common/media/audio_messages.h

+++ b/content/common/media/audio_messages.h

@@ -5,8 +5,6 @@

// IPC messages for the audio.

// Multiply-included message file, hence no include guard.

-#include <string>

#include "base/basictypes.h"

#include "base/shared_memory.h"

#include "base/sync_socket.h"

@@ -85,10 +83,6 @@ IPC_MESSAGE_CONTROL2(AudioInputMsg_NotifyStreamVolume,

int /* stream id */,

double /* volume */)

-IPC_MESSAGE_CONTROL2(AudioInputMsg_NotifyDeviceStarted,

- int /* stream id */,

- std::string /* device_id */)

// Messages sent from the renderer to the browser.

// Request that got sent to browser for creating an audio output stream

@@ -99,8 +93,8 @@ IPC_MESSAGE_CONTROL2(AudioHostMsg_CreateStream,

// Request that got sent to browser for creating an audio input stream

IPC_MESSAGE_CONTROL4(AudioInputHostMsg_CreateStream,

int /* stream_id */,

+ int /* session_id */,

media::AudioParameters /* params */,

- std::string /* device_id */,

bool /* automatic_gain_control */)

// Indicate that audio for a stream is produced by the specified render view.

@@ -147,9 +141,3 @@ IPC_MESSAGE_CONTROL2(AudioHostMsg_SetVolume,

IPC_MESSAGE_CONTROL2(AudioInputHostMsg_SetVolume,

int /* stream_id */,

double /* volume */)

-// Start the device referenced by the session_id for the input stream specified

-// by stream_id.

-IPC_MESSAGE_CONTROL2(AudioInputHostMsg_StartDevice,

- int /* stream_id */,

- int /* session_id */)