Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: media/audio/audio_input_ipc.h

Issue 12440027: Do not pass the string device_id via IPC message to create an audio input stream (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: addressed palmer's comments Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/audio_input_ipc.h
diff --git a/media/audio/audio_input_ipc.h b/media/audio/audio_input_ipc.h
index e46e6acf06016d0912049ab52adb299763f9e1cf..044ee9935469fb07a5792483743c852a4246cd6c 100644
--- a/media/audio/audio_input_ipc.h
+++ b/media/audio/audio_input_ipc.h
@@ -43,10 +43,6 @@ class MEDIA_EXPORT AudioInputIPCDelegate {
// Called when the input stream volume has changed.
virtual void OnVolume(double volume) = 0;
- // Called when a device has been started on the server side.
- // If the device could not be started, |device_id| will be empty.
- virtual void OnDeviceReady(const std::string& device_id) = 0;
-
// Called when the AudioInputIPC object is going away and/or when the
// IPC channel has been closed and no more IPC requests can be made.
// Implementations must clear any references to the AudioInputIPC object
@@ -79,17 +75,11 @@ class MEDIA_EXPORT AudioInputIPC {
// Once the stream has been created, the implementation must
// generate a notification to the AudioInputIPCDelegate and call
// OnStreamCreated().
- virtual void CreateStream(
- int stream_id,
- const AudioParameters& params,
- const std::string& device_id,
- bool automatic_gain_control,
- uint32 total_segments) = 0;
-
- // Starts the device on the server side. Once the device has started,
- // or failed to start, a callback to
- // AudioInputIPCDelegate::OnDeviceReady() must be made.
- virtual void StartDevice(int stream_id, int session_id) = 0;
+ virtual void CreateStream(int stream_id,
+ int session_id,
+ const AudioParameters& params,
+ bool automatic_gain_control,
+ uint32 total_segments) = 0;
// Corresponds to a call to AudioInputController::Record() on the server side.
virtual void RecordStream(int stream_id) = 0;

Powered by Google App Engine
This is Rietveld 408576698