content/renderer/media/webrtc_audio_device_unittest.cc - Issue 12440027: Do not pass the string device_id via IPC message to create an audio input stream

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webrtc_audio_device_unittest.cc

Issue 12440027: Do not pass the string device_id via IPC message to create an audio input stream (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: addressed palmer's comments Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/webrtc_audio_capturer.cc ('K') | « content/renderer/media/webrtc_audio_device_impl.cc ('k') | content/renderer/media/webrtc_local_audio_renderer.h » ('j') | content/renderer/pepper/pepper_platform_audio_input_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/webrtc_audio_device_unittest.cc

diff --git a/content/renderer/media/webrtc_audio_device_unittest.cc b/content/renderer/media/webrtc_audio_device_unittest.cc

index e04eafc94bb15c7b34bb3dac77dae6c785a105a4..a9c9fd1fceec8d92577dfbee7a8154dbb8e0d0f7 100644

--- a/content/renderer/media/webrtc_audio_device_unittest.cc

+++ b/content/renderer/media/webrtc_audio_device_unittest.cc

@@ -100,11 +100,9 @@ bool InitializeCapturer(WebRtcAudioDeviceImpl* webrtc_audio_device) {

int sample_rate = hardware_config->GetInputSampleRate();

media::ChannelLayout channel_layout =

hardware_config->GetInputChannelLayout();

- if (!capturer->Initialize(channel_layout, sample_rate))

+ if (!capturer->Initialize(channel_layout, sample_rate, 1))

return false;

- // Ensures that the default capture device is utilized.

- webrtc_audio_device->capturer()->SetDevice(1);

return true;

}