content/renderer/media/webrtc_audio_device_impl.h - Issue 12440027: Do not pass the string device_id via IPC message to create an audio input stream

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webrtc_audio_device_impl.h

Issue 12440027: Do not pass the string device_id via IPC message to create an audio input stream (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: addressed palmer's comments Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/webrtc_audio_capturer.cc ('K') | « content/renderer/media/webrtc_audio_capturer.cc ('k') | content/renderer/media/webrtc_audio_device_impl.cc » ('j') | content/renderer/pepper/pepper_platform_audio_input_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/webrtc_audio_device_impl.h

diff --git a/content/renderer/media/webrtc_audio_device_impl.h b/content/renderer/media/webrtc_audio_device_impl.h

index 1b825e2d2db1ac14e6fb2cd11a793957eaa728b5..99d2a72033673f10df147a1d6805e6a1092b683d 100644

--- a/content/renderer/media/webrtc_audio_device_impl.h

+++ b/content/renderer/media/webrtc_audio_device_impl.h

@@ -212,9 +212,6 @@ class WebRtcAudioCapturerSink {

// Set the format for the capture audio parameters.

virtual void SetCaptureFormat(const media::AudioParameters& params) = 0;

- // Callback to notify the client that the capturer is being stopped.

- virtual void OnCaptureDeviceStopped() = 0;

protected:

virtual ~WebRtcAudioCapturerSink() {}

};

@@ -248,7 +245,6 @@ class CONTENT_EXPORT WebRtcAudioDeviceImpl

int audio_delay_milliseconds,

double volume) OVERRIDE;

virtual void SetCaptureFormat(const media::AudioParameters& params) OVERRIDE;

- virtual void OnCaptureDeviceStopped() OVERRIDE;

// webrtc::Module implementation.

virtual int32_t ChangeUniqueId(const int32_t id) OVERRIDE;