content/renderer/media/audio_input_message_filter.h - Issue 12440027: Do not pass the string device_id via IPC message to create an audio input stream

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/audio_input_message_filter.h

Issue 12440027: Do not pass the string device_id via IPC message to create an audio input stream (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fixed the nits. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/content_browser.gypi ('k') | content/renderer/media/audio_input_message_filter.cc » ('j') | content/renderer/pepper/pepper_platform_audio_input_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/audio_input_message_filter.h

diff --git a/content/renderer/media/audio_input_message_filter.h b/content/renderer/media/audio_input_message_filter.h

index 521c4bce6bc2f33c010bc2e82669815fb0396e78..bd6a0e12623c4103e475c7897ed5a2c95089046a 100644

--- a/content/renderer/media/audio_input_message_filter.h

+++ b/content/renderer/media/audio_input_message_filter.h

@@ -42,11 +42,10 @@ class CONTENT_EXPORT AudioInputMessageFilter

virtual void RemoveDelegate(int id) OVERRIDE;

virtual void CreateStream(

int stream_id,

+ int session_id,

const media::AudioParameters& params,

- const std::string& device_id,

bool automatic_gain_control,

uint32 total_segments) OVERRIDE;

- virtual void StartDevice(int stream_id, int session_id) OVERRIDE;

virtual void RecordStream(int stream_id) OVERRIDE;

virtual void CloseStream(int stream_id) OVERRIDE;

virtual void SetVolume(int stream_id, double volume) OVERRIDE;

@@ -86,9 +85,6 @@ class CONTENT_EXPORT AudioInputMessageFilter

void OnStreamStateChanged(int stream_id,

media::AudioInputIPCDelegate::State state);

- // Notification of the opened device of an audio session.

- void OnDeviceStarted(int stream_id, const std::string& device_id);

// A map of stream ids to delegates.

IDMap<media::AudioInputIPCDelegate> delegates_;