Do not pass the string device_id via IPC message to create an audio input stream

content/renderer/media/media_stream_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/media_stream_impl.h"
 
 #include <utility>
 
 #include "base/logging.h"
 #include "base/string_number_conversions.h"
@@ skipping 477 matching lines @@
 
   while (request_it != user_media_requests_.end()) {
     if ((*request_it)->frame == frame) {
       DVLOG(1) << "MediaStreamImpl::FrameWillClose: "
                << "Cancel user media request " << (*request_it)->request_id;
       // If the request is generated, it means that the MediaStreamDispatcher
       // has generated a stream for us and we need to let the
       // MediaStreamDispatcher know that the stream is no longer wanted.
       // If not, we cancel the request and delete the request object.
       if ((*request_it)->generated) {
+        MediaStreamExtraData* extra_data = static_cast<MediaStreamExtraData*>(

[perkj_chrome, 2013/03/20 10:39:53]

Looks like all of this belongs in the same place as were you have the audio
capturer - ie move to a function in dependency_factory_ that
takes(*request_it)->descriptor as argument.

[no longer working on chromium, 2013/03/20 15:10:19]

Done.

+            (*request_it)->descriptor.extraData());
+        if (extra_data && extra_data->is_local() && extra_data->stream() &&
+            !extra_data->stream()->GetAudioTracks().empty()) {
+          // We need to stop the capturer for local media stream.

[perkj_chrome, 2013/03/20 10:39:53]

audio track - not stream

[no longer working on chromium, 2013/03/20 15:10:19]

Done.

+          // TODO(xians): Loop through audio tracks to stop their capturer if
+          // there are multiple audio tracks.
+          if (dependency_factory_->GetWebRtcAudioDevice()) {
+            scoped_refptr<WebRtcAudioCapturer> capturer =
+                dependency_factory_->GetWebRtcAudioDevice()->capturer();
+            if (capturer)
+              capturer->Stop();
+          }
+        }
+
         media_stream_dispatcher_->StopStream(

[perkj_chrome, 2013/03/20 10:39:53]

So is StopStream only used for video now or audio as well?

[no longer working on chromium, 2013/03/20 15:10:19]

both audio and video as before.

             UTF16ToUTF8((*request_it)->descriptor.label()));
       } else {
         media_stream_dispatcher_->CancelGenerateStream(
             (*request_it)->request_id);
       }
       request_it = user_media_requests_.erase(request_it);
     } else {
       ++request_it;
     }
   }
@@ skipping 80 matching lines @@
     const StreamStopCallback& stop_callback) {
   stream_stop_callback_ = stop_callback;
 }
 
 void MediaStreamExtraData::OnLocalStreamStop() {
   if (!stream_stop_callback_.is_null())
     stream_stop_callback_.Run(stream_->label());
 }
 
 }  // namespace content