Make instances of HeaderValue and ContentType immutable

pkg/http/test/request_test.dart

-// Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
+// Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library request_test;
 
 import 'dart:io';
 
 import 'package:unittest/unittest.dart';
 import '../lib/http.dart' as http;
 import '../lib/src/utils.dart';
 import 'utils.dart';
 
 void main() {
   test('.send', () {
     expect(startServer().then((_) {
 
       var request = new http.Request('POST', serverUrl);
       request.body = "hello";
 
       expect(request.send().then((response) {
         expect(response.statusCode, equals(200));
         return response.stream.bytesToString();
       }).whenComplete(stopServer), completion(parse(equals({
         'method': 'POST',
         'path': '/',
         'headers': {
-          'content-type': ['text/plain; charset=UTF-8'],
+          'content-type': ['text/plain; charset=utf-8'],
           'content-length': ['5']
         },
         'body': 'hello'
       }))));
     }), completes);
   });
 
   group('#contentLength', () {
     test('is computed from bodyBytes', () {
       var request = new http.Request('POST', dummyUrl);
@@ skipping 200 matching lines @@
       var request = new http.Request('POST', dummyUrl);
       request.encoding = Encoding.ISO_8859_1;
       expect(request.headers[HttpHeaders.CONTENT_TYPE], isNull);
     });
 
     test('is set to application/x-www-form-urlencoded with charset utf-8 if '
         'bodyFields is set', () {
       var request = new http.Request('POST', dummyUrl);
       request.bodyFields = {'hello': 'world'};
       expect(request.headers[HttpHeaders.CONTENT_TYPE],
-          equals('application/x-www-form-urlencoded; charset=UTF-8'));
+          equals('application/x-www-form-urlencoded; charset=utf-8'));
     });
 
     test('is set to application/x-www-form-urlencoded with the given charset '
         'if bodyFields and encoding are set', () {
       var request = new http.Request('POST', dummyUrl);
       request.encoding = Encoding.ISO_8859_1;
       request.bodyFields = {'hello': 'world'};
       expect(request.headers[HttpHeaders.CONTENT_TYPE],
-          equals('application/x-www-form-urlencoded; charset=ISO-8859-1'));
+          equals('application/x-www-form-urlencoded; charset=iso-8859-1'));
     });
 
     test('is set to text/plain and the given encoding if body and encoding are '
         'both set', () {
       var request = new http.Request('POST', dummyUrl);
       request.encoding = Encoding.ISO_8859_1;
       request.body = 'hello, world';
       expect(request.headers[HttpHeaders.CONTENT_TYPE],
-          equals('text/plain; charset=ISO-8859-1'));
+          equals('text/plain; charset=iso-8859-1'));
     });
 
     test('is modified to include utf-8 if body is set', () {
       var request = new http.Request('POST', dummyUrl);
       request.headers[HttpHeaders.CONTENT_TYPE] = 'application/json';
       request.body = '{"hello": "world"}';
       expect(request.headers[HttpHeaders.CONTENT_TYPE],
-          equals('application/json; charset=UTF-8'));
+          equals('application/json; charset=utf-8'));
     });
 
     test('is modified to include the given encoding if encoding is set', () {
       var request = new http.Request('POST', dummyUrl);
       request.headers[HttpHeaders.CONTENT_TYPE] = 'application/json';
       request.encoding = Encoding.ISO_8859_1;
       expect(request.headers[HttpHeaders.CONTENT_TYPE],
-          equals('application/json; charset=ISO-8859-1'));
+          equals('application/json; charset=iso-8859-1'));
     });
 
     test('has its charset overridden by an explicit encoding', () {
       var request = new http.Request('POST', dummyUrl);
       request.headers[HttpHeaders.CONTENT_TYPE] =
           'application/json; charset=utf-8';
       request.encoding = Encoding.ISO_8859_1;
       expect(request.headers[HttpHeaders.CONTENT_TYPE],
-          equals('application/json; charset=ISO-8859-1'));
+          equals('application/json; charset=iso-8859-1'));
     });
 
     test("doen't have its charset overridden by setting bodyFields", () {
       var request = new http.Request('POST', dummyUrl);
       request.headers[HttpHeaders.CONTENT_TYPE] =
           'application/x-www-form-urlencoded; charset=iso-8859-1';
       request.bodyFields = {'hello': 'world'};
       expect(request.headers[HttpHeaders.CONTENT_TYPE],
           equals('application/x-www-form-urlencoded; charset=iso-8859-1'));
     });
@@ skipping 83 matching lines @@
   });
 
   group('#toString()', () {
     test('includes the method and URL', () {
       var request = new http.Request('POST', dummyUrl);
       expect(request.toString(), 'POST $dummyUrl');
     });
   });
 }