core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp - Issue 1243953004: Re-land else-after-returns

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp

Issue 1243953004: Re-land else-after-returns (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp

diff --git a/core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp b/core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp

index 5b5703b868c5b09263b124ab709c85284eee8438..892e2153b7432c27ab8bf1f6105c39dcfce23761 100644

--- a/core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp

+++ b/core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp

@@ -337,7 +337,8 @@ FX_BOOL CPDF_StreamContentParser::OnOperator(const FX_CHAR* op)

if (compare == 0) {

(this->*g_OpCodes[middle].m_OpHandler)();

return TRUE;

- } else if (compare < 0) {

+ }

+ if (compare < 0) {

high = middle - 1;

} else {

low = middle + 1;