core/src/fxcodec/codec/fx_codec_icc.cpp - Issue 1243953004: Re-land else-after-returns

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxcodec/codec/fx_codec_icc.cpp

Issue 1243953004: Re-land else-after-returns (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fxcodec/codec/fx_codec_icc.cpp

diff --git a/core/src/fxcodec/codec/fx_codec_icc.cpp b/core/src/fxcodec/codec/fx_codec_icc.cpp

index da503c03fd1a09b0bbb471e9f5de33b89bd53bd4..7507fe5d6d505263961c3ddd65c92b6533e1043f 100644

--- a/core/src/fxcodec/codec/fx_codec_icc.cpp

+++ b/core/src/fxcodec/codec/fx_codec_icc.cpp

@@ -44,7 +44,8 @@ FX_BOOL CheckComponents(cmsColorSpaceSignature cs, int nComponents, FX_BOOL bDst

case cmsSigGrayData:

if (bDst && nComponents != 1) {

return FALSE;

- } else if (!bDst && nComponents > 2) {

+ }

+ if (!bDst && nComponents > 2) {

return FALSE;

}

break;

« no previous file with comments | « core/src/fpdftext/text_int.h ('k') | core/src/fxcodec/codec/fx_codec_jbig.cpp » ('j') | no next file with comments »