core/src/fxcrt/fx_basic_array.cpp - Issue 1243953004: Re-land else-after-returns

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxcrt/fx_basic_array.cpp

Issue 1243953004: Re-land else-after-returns (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fxcrt/fx_basic_array.cpp

diff --git a/core/src/fxcrt/fx_basic_array.cpp b/core/src/fxcrt/fx_basic_array.cpp

index 56b2f57f3c48261182f9e0dfab1e41350e0eee1b..4ab34bb022bf6303fd925c9e8e794aaa646d8b3d 100644

--- a/core/src/fxcrt/fx_basic_array.cpp

+++ b/core/src/fxcrt/fx_basic_array.cpp

@@ -243,7 +243,8 @@ void** CFX_BaseSegmentedArray::GetIndex(int seg_index) const

ASSERT(m_IndexDepth != 0);

if (m_IndexDepth == 1) {

return (void**)m_pIndex;

- } else if (m_IndexDepth == 2) {

+ }

+ if (m_IndexDepth == 2) {

return (void**)((void**)m_pIndex)[seg_index / m_IndexSize];

}

int tree_size = 1;

« no previous file with comments | « core/src/fxcodec/codec/fx_codec_jpeg.cpp ('k') | core/src/fxcrt/fx_basic_bstring.cpp » ('j') | no next file with comments »