core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp - Issue 1243953004: Re-land else-after-returns

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp

Issue 1243953004: Re-land else-after-returns (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp

diff --git a/core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp b/core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp

index 6d425de6f854bc7485465bf8fd867af1e4131565..4903312645b7230083d959cd7519d148ef9113c9 100644

--- a/core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp

+++ b/core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp

@@ -165,7 +165,8 @@ CFX_ByteStringC CPDF_SimpleParser::GetWord()

m_dwCurPos ++;

}

return CFX_ByteStringC(pStart, (FX_STRSIZE)(m_dwCurPos - (pStart - m_pData)));

- } else if (dwSize == 1 && pStart[0] == '(') {

+ }

+ if (dwSize == 1 && pStart[0] == '(') {

int level = 1;

while (m_dwCurPos < m_dwSize) {

if (m_pData[m_dwCurPos] == ')') {