Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issue 1243923002: Shorten audio_modem test_support target to just "test_support". (Closed)

Created:
5 years, 5 months ago by tfarina
Modified:
5 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Shorten audio_modem test_support target to just "test_support". In GN we can just do //components/audio_modem:test_support, we don't need the 'audio_modem' redundance twice here. Also turned it from a static library into a source set. BUG=None R=brettw@chromium.org Committed: https://crrev.com/4df99d351d6f65520f49670dd89f3a13c647b24f Cr-Commit-Position: refs/heads/master@{#339911}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/audio_modem/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
tfarina
Hi Brett, could you review this to me?
5 years, 5 months ago (2015-07-20 23:37:54 UTC) #1
tfarina
Brett, ping?
5 years, 5 months ago (2015-07-22 14:21:18 UTC) #2
brettw
lgtm
5 years, 5 months ago (2015-07-22 16:04:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1243923002/1
5 years, 5 months ago (2015-07-22 17:26:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-22 17:58:52 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-22 17:59:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4df99d351d6f65520f49670dd89f3a13c647b24f
Cr-Commit-Position: refs/heads/master@{#339911}

Powered by Google App Engine
This is Rietveld 408576698