core/src/fxge/win32/fx_win32_gdipext.cpp - Issue 1243883003: Fix else-after-returns throughout pdfium.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxge/win32/fx_win32_gdipext.cpp

Issue 1243883003: Fix else-after-returns throughout pdfium. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Rebase, Address comments. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fxge/win32/fx_win32_gdipext.cpp

diff --git a/core/src/fxge/win32/fx_win32_gdipext.cpp b/core/src/fxge/win32/fx_win32_gdipext.cpp

index 8fef914cd8aa374045fdc144c452443f4e391b51..d76d52e50b98e49b51864341a75e6fc2eab5887f 100644

--- a/core/src/fxge/win32/fx_win32_gdipext.cpp

+++ b/core/src/fxge/win32/fx_win32_gdipext.cpp

@@ -1010,14 +1010,14 @@ public:

virtual HRESULT STDMETHODCALLTYPE

QueryInterface(REFIID iid, void ** ppvObject)

{

- if (iid == __uuidof(IUnknown) || iid == __uuidof(IStream) ||

- iid == __uuidof(ISequentialStream)) {

+ if (iid == __uuidof(IUnknown) ||

+ iid == __uuidof(IStream) ||

+ iid == __uuidof(ISequentialStream)) {

*ppvObject = static_cast<IStream*>(this);

AddRef();

return S_OK;

- } else {

- return E_NOINTERFACE;

}

+ return E_NOINTERFACE;

}

virtual ULONG STDMETHODCALLTYPE AddRef(void)

{

« no previous file with comments | « core/src/fxge/win32/fx_win32_dwrite.cpp ('k') | core/src/fxge/win32/fx_win32_print.cpp » ('j') | no next file with comments »