core/src/fpdftext/text_int.h - Issue 1243883003: Fix else-after-returns throughout pdfium.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdftext/text_int.h

Issue 1243883003: Fix else-after-returns throughout pdfium. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Rebase, Address comments. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdftext/text_int.h

diff --git a/core/src/fpdftext/text_int.h b/core/src/fpdftext/text_int.h

index 6eb6ca5a74e6a16536172a48fe4ec077737c04cf..6fbb04849aa8be8931a45ff156d018d4cf4ebe4c 100644

--- a/core/src/fpdftext/text_int.h

+++ b/core/src/fpdftext/text_int.h

@@ -74,7 +74,6 @@ public:

FX_FLOAT yTorelance) const;

virtual CFX_WideString GetTextByRect(const CFX_FloatRect& rect) const;

virtual void GetRectsArrayByRect(const CFX_FloatRect& rect, CFX_RectArray& resRectArray) const;

- virtual int GetOrderByDirection(int order, int direction) const;

virtual CFX_WideString GetPageText(int start = 0, int nCount = -1) const;

virtual int CountRects(int start, int nCount);

@@ -95,7 +94,7 @@ public:

static FX_BOOL IsLetter(FX_WCHAR unicode);

private:

FX_BOOL IsHyphen(FX_WCHAR curChar);

- FX_BOOL IsControlChar(PAGECHAR_INFO* pCharInfo);

+ bool IsControlChar(const PAGECHAR_INFO& charInfo);

FX_BOOL GetBaselineRotate(int start, int end, int& Rotate);

void ProcessObject();

void ProcessFormObject(CPDF_FormObject* pFormObj, const CFX_AffineMatrix& formMatrix);

« no previous file with comments | « core/src/fpdftext/fpdf_text_int.cpp ('k') | core/src/fxcodec/codec/fx_codec_icc.cpp » ('j') | no next file with comments »